[Impeller] started asserting test runners have fatal validations

Author: gaaclarke

impeller/base/BUILD.gn

@@ -32,7 +32,10 @@ impeller_component("base") {
 
 impeller_component("base_unittests") {
   testonly = true
-  sources = [ "base_unittests.cc" ]
+  sources = [
+    "base_unittests.cc",
+    "validation_unittests.cc",
+  ]
   deps = [
     ":base",
     "//flutter/testing",

impeller/base/validation.cc

@@ -11,7 +11,7 @@
 namespace impeller {
 
 static std::atomic_int32_t sValidationLogsDisabledCount = 0;
-static std::atomic_int32_t sValidationLogsAreFatal = 0;
+static std::atomic_int32_t sValidationLogsAreFatal = 1;
 
 void ImpellerValidationErrorsSetFatal(bool fatal) {
   sValidationLogsAreFatal = fatal;
@@ -59,4 +59,15 @@ void ImpellerValidationBreak(const char* message) {
 #endif  // IMPELLER_ENABLE_VALIDATION
 }
 
+bool ImpellerValidationIsFatal() {
+  return sValidationLogsAreFatal;
+}
+
+bool ImpellerValidationIsEnabled() {
+#ifdef IMPELLER_ENABLE_VALIDATION
+  return true;
+#else
+  return false;
+#endif
+}
 }  // namespace impeller

impeller/base/validation.h

@@ -39,6 +39,10 @@ void ImpellerValidationBreak(const char* message);
 
 void ImpellerValidationErrorsSetFatal(bool fatal);
 
+bool ImpellerValidationIsFatal();
+
+bool ImpellerValidationIsEnabled();
+
 struct ScopedValidationDisable {
   ScopedValidationDisable();
 

impeller/base/validation_unittests.cc

@@ -0,0 +1,18 @@
+// Copyright 2013 The Flutter Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "flutter/testing/testing.h"
+#include "impeller/base/validation.h"
+
+namespace impeller {
+
+TEST(ValidationTest, IsFatal) {
+  EXPECT_TRUE(ImpellerValidationIsFatal());
+}
+
+TEST(ValidationTest, IsEnabled) {
+  EXPECT_TRUE(ImpellerValidationIsEnabled());
+}
+
+}  // namespace impeller