review

Author: LongCatIsLooong

shell/platform/android/io/flutter/embedding/android/KeyboardManager.java

@@ -9,7 +9,6 @@
 import androidx.annotation.NonNull;
 import io.flutter.Log;
 import io.flutter.embedding.android.KeyboardManager.Responder.OnKeyEventHandledCallback;
-import io.flutter.embedding.engine.systemchannels.KeyEventChannel;
 import io.flutter.plugin.editing.TextInputPlugin;
 import java.util.HashSet;
 
@@ -37,9 +36,9 @@
  *       <p>When a new {@link KeyEvent} is received, {@link KeyboardManager} calls the {@link
  *       Responder#handleEvent(KeyEvent, OnKeyEventHandledCallback)} method on its {@link
  *       Responder}s. Each {@link Responder} must call the supplied {@link
- *       OnKeyEventHandledCallback} exactly once, when it has decided wether to handle the key event
- *       callback. More than one {@link Responder} is allowed to reply true and handle the same
- *       {@link KeyEvent}.
+ *       OnKeyEventHandledCallback} exactly once, when it has decided whether to handle the key
+ *       event callback. More than one {@link Responder} is allowed to reply true and handle the
+ *       same {@link KeyEvent}.
  *       <p>Typically a {@link KeyboardManager} uses a {@link KeyChannelResponder} as its only
  *       {@link Responder}.
  *   <li>{@link TextInputPlugin}: if every {@link Responder} has replied false to a {@link
@@ -83,14 +82,6 @@ public KeyboardManager(
     this.responders = responders;
   }
 
-  KeyboardManager(
-      View view, @NonNull TextInputPlugin textInputPlugin, KeyEventChannel keyEventChannel) {
-    this(
-        view,
-        textInputPlugin,
-        new KeyboardManager.Responder[] {new KeyChannelResponder(keyEventChannel)});
-  }
-
   /**
    * The interface for responding to a {@link KeyEvent} asynchronously.
    *

shell/platform/android/test/io/flutter/embedding/android/KeyboardManagerTest.java

@@ -80,7 +80,11 @@ public void setUp() {
     when(mockRootView.dispatchKeyEvent(any(KeyEvent.class)))
         .thenAnswer(
             invocation -> mockView.dispatchKeyEvent((KeyEvent) invocation.getArguments()[0]));
-    keyboardManager = new KeyboardManager(mockView, mockTextInputPlugin, mockKeyEventChannel);
+    keyboardManager =
+        new KeyboardManager(
+            mockView,
+            mockTextInputPlugin,
+            new Responder[] {new KeyChannelResponder(flutterEngine.getKeyEventChannel())});
   }
 
   // Tests start