Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 0fccf6f

Browse files
committed
Address comments
1 parent b985ae5 commit 0fccf6f

File tree

1 file changed

+4
-21
lines changed

1 file changed

+4
-21
lines changed

impeller/entity/entity_pass.cc

Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -129,13 +129,8 @@ std::optional<Rect> EntityPass::GetElementsCoverage(
129129
if (backdrop_filter) {
130130
auto backdrop_coverage = backdrop_filter->GetCoverage({});
131131
if (backdrop_coverage.has_value()) {
132-
backdrop_coverage->origin += accumulated_coverage->origin;
133-
if (unfiltered_coverage.has_value()) {
134-
unfiltered_coverage =
135-
unfiltered_coverage->Union(*backdrop_coverage);
136-
} else {
137-
unfiltered_coverage = backdrop_coverage;
138-
}
132+
unfiltered_coverage =
133+
Union(backdrop_coverage.value(), unfiltered_coverage);
139134
}
140135
} else {
141136
VALIDATION_LOG << "The EntityPass backdrop filter proc didn't return "
@@ -166,24 +161,12 @@ std::optional<Rect> EntityPass::GetElementsCoverage(
166161
element_coverage = unfiltered_coverage;
167162
}
168163

169-
if (element_coverage.has_value() && coverage_limit.has_value() &&
170-
(!image_filter || image_filter->IsTranslationOnly())) {
171-
element_coverage =
172-
element_coverage->Intersection(coverage_limit.value());
173-
}
164+
element_coverage = element_coverage->Intersection(coverage_limit.value());
174165
} else {
175166
FML_UNREACHABLE();
176167
}
177168

178-
if (!accumulated_coverage.has_value() && element_coverage.has_value()) {
179-
accumulated_coverage = element_coverage;
180-
continue;
181-
}
182-
if (!element_coverage.has_value()) {
183-
continue;
184-
}
185-
accumulated_coverage =
186-
accumulated_coverage->Union(element_coverage.value());
169+
accumulated_coverage = Union(accumulated_coverage, element_coverage);
187170
}
188171
return accumulated_coverage;
189172
}

0 commit comments

Comments
 (0)