be sure to keep the fonts alive for the two loops

Bug: skia:10124
Change-Id: I449b72a00d714207a6bbc7948b5cdbb9a541b43f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/287819
Reviewed-by: Ben Wagner <[email protected]>
Commit-Queue: Mike Reed <[email protected]>

Author: reed-at-google

modules/skshaper/src/SkShaper_coretext.cpp

@@ -210,6 +210,7 @@ void SkShaper_CoreText::shape(const char* utf8, size_t utf8Bytes,
 
     // We have to compute RunInfos in a loop, and then reuse them in a 2nd loop,
     // so we store them in an array (we reuse the array's storage for each line).
+    std::vector<SkFont> fontStorage;
     std::vector<SkShaper::RunHandler::RunInfo> infos;
 
     LineBreakIter iter(typesetter.get(), width);
@@ -220,6 +221,7 @@ void SkShaper_CoreText::shape(const char* utf8, size_t utf8Bytes,
             continue;
         }
         handler->beginLine();
+        fontStorage.clear();
         infos.clear();
         for (CFIndex j = 0; j < runCount; ++j) {
             CTRunRef run = (CTRunRef)CFArrayGetValueAtIndex(run_array, j);
@@ -237,10 +239,10 @@ void SkShaper_CoreText::shape(const char* utf8, size_t utf8Bytes,
 
             CFRange range = CTRunGetStringRange(run);
 
-            SkFont run_font = run_to_font(run, font);
+            fontStorage.push_back(run_to_font(run, font));
             infos.push_back({
-                run_font,
-                0,      // need fBidiLevel
+                fontStorage.back(), // info just stores a ref to the font
+                0,                  // need fBidiLevel
                 {adv, 0},
                 (size_t)runGlyphs,
                 {(size_t)range.location, (size_t)range.length},