Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 0ae9b10

Browse files
authored
Fix dart analysis (#27367)
1 parent b57c502 commit 0ae9b10

File tree

3 files changed

+12
-9
lines changed

3 files changed

+12
-9
lines changed

ci/analyze.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ function analyze() (
6262
echo "Analyzing dart:ui library..."
6363
analyze \
6464
--options "$FLUTTER_DIR/analysis_options.yaml" \
65-
"$SRC_DIR/out/host_debug_unopt/gen/sky/bindings/dart_ui/ui.dart"
65+
"$SRC_DIR/out/host_debug_unopt/gen/dart-pkg/sky_engine/lib/ui/ui.dart"
6666

6767
echo "Analyzing spirv library..."
6868
analyze \

lib/snapshot/BUILD.gn

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,10 @@ import("//flutter/common/config.gni")
88
import("//flutter/lib/ui/dart_ui.gni")
99
import("//third_party/dart/utils/compile_platform.gni")
1010

11-
bindings_output_dir = "$root_gen_dir/sky/bindings"
12-
13-
copy("generate_dart_ui") {
11+
# TODO(dnfield): Remove this when recipes are updated to not use it.
12+
# https://flutter-review.googlesource.com/c/recipes/+/15420
13+
group("generate_dart_ui") {
1414
visibility = [ ":*" ]
15-
sources = dart_ui_files
16-
17-
outputs = [ "$bindings_output_dir/dart_ui/{{source_file_part}}" ]
1815
}
1916

2017
compiled_action("generate_snapshot_bin") {

lib/ui/semantics.dart

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -662,10 +662,16 @@ abstract class StringAttribute extends NativeFieldWrapperClass1 {
662662
required this.range,
663663
});
664664

665-
// The range of the text to which this attribute applies.
665+
/// The range of the text to which this attribute applies.
666666
final TextRange range;
667667

668-
// Returns a copy of this atttribute with the given range.
668+
/// Creates a new attribute with all properties copied except for range, which
669+
/// is updated to the specified value.
670+
///
671+
/// For example, the [LocaleStringAttribute] specifies a [Locale] for its
672+
/// range of characters. Copying it will result in a new
673+
/// [LocaleStringAttribute] that has the same locale but an updated
674+
/// [TextRange].
669675
StringAttribute copy({required TextRange range});
670676
}
671677

0 commit comments

Comments
 (0)