From 9a257c35c8d05829e7cfa988f346275f9c9a90a6 Mon Sep 17 00:00:00 2001 From: Stuart Morgan Date: Thu, 15 Oct 2020 12:45:04 -0700 Subject: [PATCH] Remove /FC from Windows builds This is incompatible with recent goma updates. Rather than make it conditional on goma, it is removed entirely based on the arguments given in https://source.chromium.org/chromium/chromium/src/+/2e6d17c6948b2ca1e4dbd6bf15fcb52d32fa338d --- build/toolchain/win/BUILD.gn | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn index ecb8d9e3fe..d3759c8040 100644 --- a/build/toolchain/win/BUILD.gn +++ b/build/toolchain/win/BUILD.gn @@ -94,7 +94,7 @@ template("msvc_toolchain") { # TODO(brettw) enable this when GN support in the binary has been rolled. #precompiled_header_type = "msvc" pdbname = "{{target_out_dir}}/{{target_output_name}}_c.pdb" - command = "ninja -t msvc -e $env -- $cl /nologo /showIncludes /FC @$rspfile /c {{source}} /Fo{{output}} /Fd$pdbname" + command = "ninja -t msvc -e $env -- $cl /nologo /showIncludes @$rspfile /c {{source}} /Fo{{output}} /Fd$pdbname" depsformat = "msvc" description = "CC {{output}}" outputs = [ @@ -115,7 +115,7 @@ template("msvc_toolchain") { if (is_clang && invoker.current_cpu == "x86") { flags = "-m32" } - command = "ninja -t msvc -e $env -- $cl $flags /nologo /showIncludes /FC @$rspfile /c {{source}} /Fo{{output}} /Fd$pdbname" + command = "ninja -t msvc -e $env -- $cl $flags /nologo /showIncludes @$rspfile /c {{source}} /Fo{{output}} /Fd$pdbname" depsformat = "msvc" description = "CXX {{output}}" outputs = [