Skip to content

[google_maps_flutter] Use completer to get map id #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2022
Merged

[google_maps_flutter] Use completer to get map id #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/google_maps_flutter/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## NEXT

* Fix integration test failures

## 0.1.3

* Resolve linter warnings.
Expand Down
30 changes: 15 additions & 15 deletions packages/google_maps_flutter/example/integration_test/google_maps_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ void main() {
testWidgets('updateMinMaxZoomLevels', (WidgetTester tester) async {
final Key key = GlobalKey();
late GoogleMapsPlugin plugin;
int mapId = -1;
final Completer<int> mapIdCompleter = Completer<int>();

const MinMaxZoomPreference initialZoomLevel = MinMaxZoomPreference(4, 8);
const MinMaxZoomPreference finalZoomLevel = MinMaxZoomPreference(6, 10);
Expand All @@ -34,11 +34,11 @@ void main() {
initialCameraPosition: _kInitialCameraPosition,
minMaxZoomPreference: initialZoomLevel,
onMapCreated: (GoogleMapController c) {
mapId = c.mapId;
mapIdCompleter.complete(c.mapId);
},
),
));

final int mapId = await mapIdCompleter.future;
await tester.pumpAndSettle();
await tester.pumpAndSettle(const Duration(seconds: 3));

Expand Down Expand Up @@ -68,7 +68,7 @@ void main() {
testWidgets('testZoomGesturesEnabled', (WidgetTester tester) async {
final Key key = GlobalKey();
late GoogleMapsPlugin plugin;
int mapId = -1;
final Completer<int> mapIdCompleter = Completer<int>();

await tester.pumpWidget(Directionality(
textDirection: TextDirection.ltr,
Expand All @@ -77,11 +77,11 @@ void main() {
initialCameraPosition: _kInitialCameraPosition,
zoomGesturesEnabled: false,
onMapCreated: (GoogleMapController c) {
mapId = c.mapId;
mapIdCompleter.complete(c.mapId);
},
),
));

final int mapId = await mapIdCompleter.future;
await tester.pumpAndSettle();
await tester.pumpAndSettle(const Duration(seconds: 3));

Expand Down Expand Up @@ -110,19 +110,19 @@ void main() {
testWidgets('testZoomControlsEnabled', (WidgetTester tester) async {
final Key key = GlobalKey();
late GoogleMapsPlugin plugin;
int mapId = -1;
final Completer<int> mapIdCompleter = Completer<int>();

await tester.pumpWidget(Directionality(
textDirection: TextDirection.ltr,
child: GoogleMap(
key: key,
initialCameraPosition: _kInitialCameraPosition,
onMapCreated: (GoogleMapController c) {
mapId = c.mapId;
mapIdCompleter.complete(c.mapId);
},
),
));

final int mapId = await mapIdCompleter.future;
await tester.pumpAndSettle();
await tester.pumpAndSettle(const Duration(seconds: 2));

Expand Down Expand Up @@ -152,7 +152,7 @@ void main() {
testWidgets('testScrollGesturesEnabled', (WidgetTester tester) async {
final Key key = GlobalKey();
late GoogleMapsPlugin plugin;
int mapId = -1;
final Completer<int> mapIdCompleter = Completer<int>();

await tester.pumpWidget(Directionality(
textDirection: TextDirection.ltr,
Expand All @@ -161,11 +161,11 @@ void main() {
initialCameraPosition: _kInitialCameraPosition,
scrollGesturesEnabled: false,
onMapCreated: (GoogleMapController c) {
mapId = c.mapId;
mapIdCompleter.complete(c.mapId);
},
),
));

final int mapId = await mapIdCompleter.future;
await tester.pumpAndSettle();
await tester.pumpAndSettle(const Duration(seconds: 3));

Expand Down Expand Up @@ -302,7 +302,7 @@ void main() {
testWidgets('testTraffic', (WidgetTester tester) async {
final Key key = GlobalKey();
late GoogleMapsPlugin plugin;
int mapId = -1;
final Completer<int> mapIdCompleter = Completer<int>();

await tester.pumpWidget(Directionality(
textDirection: TextDirection.ltr,
Expand All @@ -311,11 +311,11 @@ void main() {
initialCameraPosition: _kInitialCameraPosition,
trafficEnabled: true,
onMapCreated: (GoogleMapController c) {
mapId = c.mapId;
mapIdCompleter.complete(c.mapId);
},
),
));

final int mapId = await mapIdCompleter.future;
await tester.pumpAndSettle();
await tester.pumpAndSettle(const Duration(seconds: 3));

Expand Down