Skip to content

Commit 81a670c

Browse files
authored
[firebase_core] Minor cleanups (#502)
1 parent bef9090 commit 81a670c

File tree

7 files changed

+28
-19
lines changed

7 files changed

+28
-19
lines changed
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
## NEXT
2+
3+
* Update firebase_core to 2.4.0.
4+
* Update firebase_core_platform_interface to 4.5.2.
5+
* Rename `firebase_app_desktop.dart` to `firebase_app_tizen.dart`.
6+
17
## 0.1.0
28

39
* Initial release.

packages/firebase_core/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@ This package is not an _endorsed_ implementation of `firebase_core`. Therefore,
1010

1111
```yaml
1212
dependencies:
13-
firebase_core: ^1.9.0
13+
firebase_core: ^2.4.0
1414
firebase_core_tizen: ^0.1.0
1515
```
1616
17-
For detailed usage see https://github.com/invertase/flutterfire_desktop#flutterfire-desktop.
17+
For detailed usage, see https://github.com/invertase/flutterfire_desktop#flutterfire-desktop.
1818
1919
## Tizen integration
2020
21-
The implementation of `firebase_core` is based on [FlutterFire Desktop Core](https://github.com/invertase/flutterfire_desktop/tree/main/packages/firebase_core/firebase_core_desktop). FlutterFire Desktop provides dart implementation of the Firebase modules.
21+
The implementation of `firebase_core_tizen` is based on [FlutterFire Desktop Core](https://github.com/invertase/flutterfire_desktop/tree/main/packages/firebase_core/firebase_core_desktop). FlutterFire Desktop provides Dart implementation of the Firebase modules.

packages/firebase_core/example/lib/main.dart

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
// Copyright (c) Invertase Limited <[email protected]> & Contributors
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
25
// ignore_for_file: public_member_api_docs
36

47
import 'dart:async';
@@ -13,13 +16,11 @@ class MyApp extends StatelessWidget {
1316

1417
String get name => 'foo';
1518

16-
// fill app keys if needed, you can take ones from
17-
// https://github.com/invertase/flutterfire_desktop/blob/main/packages/firebase_core/firebase_core_desktop/example/lib/main.dart
1819
FirebaseOptions get firebaseOptions => const FirebaseOptions(
19-
appId: 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx',
20-
apiKey: 'yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy',
20+
appId: '1:448618578101:ios:0b650370bb29e29cac3efc',
21+
apiKey: 'AIzaSyAgUhHU8wSJgO5MVNy95tMT07NEjzMOfz0',
2122
projectId: 'react-native-firebase-testing',
22-
messagingSenderId: 'zzzzzzzzzzzz',
23+
messagingSenderId: '448618578101',
2324
);
2425

2526
Future<void> initializeDefault() async {

packages/firebase_core/example/pubspec.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
name: firebase_core_tizen_example
22
description: An example application demonstrating calls to Firebase Core.
3-
publish_to: 'none'
3+
publish_to: "none"
44

55
environment:
6-
sdk: ">=2.18.0 <3.0.0"
6+
sdk: ">=2.17.0 <3.0.0"
77
flutter: ">=2.5.0"
88

99
dependencies:
10-
firebase_core: ^1.9.0
10+
firebase_core: ^2.4.0
1111
firebase_core_tizen:
1212
path: ../
1313
flutter:

packages/firebase_core/lib/firebase_app_desktop.dart renamed to packages/firebase_core/lib/firebase_app_tizen.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// Use of this source code is governed by a BSD-style license
33
// that can be found in the LICENSE file.
44

5-
part of 'firebase_core_tizen.dart';
5+
part of firebase_core_tizen;
66

77
/// A Dart only implementation of a Firebase app instance.
88
class FirebaseApp extends FirebaseAppPlatform {

packages/firebase_core/lib/firebase_core_tizen.dart

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,11 @@ library firebase_core_tizen;
77
import 'package:firebase_core_dart/firebase_core_dart.dart' as core_dart;
88
import 'package:firebase_core_platform_interface/firebase_core_platform_interface.dart';
99

10-
part 'firebase_app_desktop.dart';
10+
part 'firebase_app_tizen.dart';
1111

12-
/// Desktop implementation of FirebaseCore for managing Firebase app
13-
/// instances.
12+
/// Tizen implementation of FirebaseCore for managing Firebase app instances.
1413
class FirebaseCore extends FirebasePlatform {
15-
/// Called by PluginRegistry to register this plugin as the implementation for Desktop
14+
/// Registers this class as the default instance of [FirebasePlatform].
1615
static void register() {
1716
FirebasePlatform.instance = FirebaseCore();
1817
}
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
name: firebase_core_tizen
22
description: Firebase Core for Tizen
3-
version: 0.1.0
43
homepage: https://github.com/flutter-tizen/plugins
54
repository: https://github.com/flutter-tizen/plugins/tree/master/packages/firebase_core
5+
version: 0.1.0
66

77
environment:
8-
sdk: '>=2.18.0 <3.0.0'
8+
sdk: ">=2.17.0 <3.0.0"
99
flutter: ">=2.5.0"
1010

1111
dependencies:
1212
firebase_core_dart: ^1.0.1
13-
firebase_core_platform_interface: '>=4.5.0 <4.5.2'
13+
firebase_core_platform_interface: ^4.5.2
1414
flutter:
1515
sdk: flutter
1616

@@ -19,3 +19,6 @@ flutter:
1919
platforms:
2020
tizen:
2121
dartPluginClass: FirebaseCore
22+
23+
false_secrets:
24+
- /example/lib/main.dart

0 commit comments

Comments
 (0)