Fix api name and description

Author: JSUYA

shell/platform/tizen/channels/window_channel.h

@@ -26,7 +26,7 @@ class WindowChannel {
 
   std::unique_ptr<MethodChannel<EncodableValue>> channel_;
 
-  // A reference to the renderer object managed by FlutterTizenView.s
+  // A reference to the renderer object managed by FlutterTizenView.
   TizenWindow* window_;
 };
 

shell/platform/tizen/flutter_tizen.cc

@@ -71,9 +71,10 @@ void FlutterDesktopEngineShutdown(FlutterDesktopEngineRef engine_ref) {
 
 void* FlutterDesktopPluginRegistrarGetNativeWindow(
     FlutterDesktopPluginRegistrarRef registrar) {
-  auto view_base = registrar->engine->view()->tizen_view();
-  if (view_base->GetType() == "window") {
-    auto window = reinterpret_cast<flutter::TizenWindow*>(view_base);
+  flutter::TizenViewBase* tizen_view_base =
+      registrar->engine->view()->tizen_view_base();
+  if (tizen_view_base->GetType() == "window") {
+    auto window = reinterpret_cast<flutter::TizenWindow*>(tizen_view_base);
     return window->GetWindowHandle();
   }
   return nullptr;

shell/platform/tizen/flutter_tizen_ecore.cc

@@ -6,6 +6,7 @@
 
 #include "flutter/shell/platform/tizen/flutter_tizen_engine.h"
 #include "flutter/shell/platform/tizen/flutter_tizen_view.h"
+#include "flutter/shell/platform/tizen/logger.h"
 #include "flutter/shell/platform/tizen/tizen_window_ecore_wl2.h"
 
 namespace {
@@ -57,18 +58,20 @@ FlutterDesktopViewRef FlutterDesktopViewCreateFromElmParent(
     const FlutterDesktopViewProperties& view_properties,
     FlutterDesktopEngineRef engine,
     void* parent) {
-  // Not supported.
-
+  // FIXME: Ecore WL2 renderer does not support this yet.
+  FT_UNIMPLEMENTED();
   return nullptr;
 }
 
 void* FlutterDesktopViewGetEvasObject(FlutterDesktopViewRef view) {
-  // Not supported.
+  // FIXME: Ecore WL2 renderer does not support this yet.
+  FT_UNIMPLEMENTED();
   return nullptr;
 }
 
 void FlutterDesktopViewResizeView(FlutterDesktopViewRef view,
                                   int32_t width,
                                   int32_t height) {
-  // Not supported.
-}
+  // FIXME: Ecore WL2 renderer does not support this yet.
+  FT_UNIMPLEMENTED();
+}

shell/platform/tizen/flutter_tizen_elementary.cc

@@ -66,8 +66,8 @@ FlutterDesktopViewRef FlutterDesktopViewCreateFromElmParent(
   };
 
   std::unique_ptr<flutter::TizenViewBase> view =
-      std::make_unique<flutter::TizenViewElementary>(view_geometry,
-                                                     (Evas_Object*)(parent));
+      std::make_unique<flutter::TizenViewElementary>(
+          view_geometry, static_cast<Evas_Object*>(parent));
 
   auto flutter_view =
       std::make_unique<flutter::FlutterTizenView>(std::move(view));
@@ -89,7 +89,7 @@ FlutterDesktopViewRef FlutterDesktopViewCreateFromElmParent(
 
 void* FlutterDesktopViewGetEvasObject(FlutterDesktopViewRef view) {
   auto flutter_tizen_view = reinterpret_cast<flutter::FlutterTizenView*>(view);
-  return flutter_tizen_view->tizen_view()->GetRenderTarget();
+  return flutter_tizen_view->tizen_view_base()->GetRenderTarget();
 }
 
 void FlutterDesktopViewResizeView(FlutterDesktopViewRef view,
@@ -102,5 +102,5 @@ void FlutterDesktopViewResizeView(FlutterDesktopViewRef view,
       width,
       height,
   };
-  flutter_tizen_view->tizen_view()->OnGeometryChanged(view_geometry);
+  flutter_tizen_view->tizen_view_base()->OnGeometryChanged(view_geometry);
 }

shell/platform/tizen/flutter_tizen_engine.cc

@@ -537,7 +537,7 @@ void FlutterTizenEngine::OnUpdateSemanticsCustomActions(
       std::shared_ptr<FlutterPlatformWindowDelegateTizen> window =
           FlutterPlatformAppDelegateTizen::GetInstance().GetWindow().lock();
       TizenViewBase::Geometry geometry =
-          engine->view_->tizen_view()->GetRenderTargetGeometry();
+          engine->view_->tizen_view_base()->GetRenderTargetGeometry();
       window->SetGeometry(geometry.left, geometry.top, geometry.width,
                           geometry.height);
       window->SetRootNode(root);

shell/platform/tizen/flutter_tizen_view.cc

@@ -41,9 +41,9 @@ const std::vector<std::string> kBindableSystemKeys = {
 namespace flutter {
 
 FlutterTizenView::FlutterTizenView(std::unique_ptr<TizenViewBase> tizen_view)
-    : tizen_view_(std::move(tizen_view)) {
-  tizen_view_->SetView(this);
-  tizen_view_->BindKeys(kBindableSystemKeys);
+    : tizen_view_base_(std::move(tizen_view)) {
+  tizen_view_base_->SetView(this);
+  tizen_view_base_->BindKeys(kBindableSystemKeys);
 }
 
 FlutterTizenView::~FlutterTizenView() {}
@@ -58,8 +58,8 @@ void FlutterTizenView::SetEngine(std::unique_ptr<FlutterTizenEngine> engine) {
   // Set up window dependent channels.
   BinaryMessenger* messenger = internal_plugin_registrar_->messenger();
 
-  if (tizen_view_->GetType() == "window") {
-    auto window = reinterpret_cast<TizenWindow*>(tizen_view_.get());
+  if (tizen_view_base_->GetType() == "window") {
+    auto window = reinterpret_cast<TizenWindow*>(tizen_view_base_.get());
     platform_channel_ = std::make_unique<PlatformChannel>(messenger, window);
     window_channel_ = std::make_unique<WindowChannel>(messenger, window);
   } else {
@@ -69,15 +69,17 @@ void FlutterTizenView::SetEngine(std::unique_ptr<FlutterTizenEngine> engine) {
 
   text_input_channel_ = std::make_unique<TextInputChannel>(
       internal_plugin_registrar_->messenger(),
-      tizen_view_->input_method_context());
+      tizen_view_base_->input_method_context());
 }
 
 void FlutterTizenView::CreateRenderSurface() {
   if (engine_ && engine_->renderer()) {
-    TizenViewBase::Geometry geometry = tizen_view_->GetRenderTargetGeometry();
-    engine_->renderer()->CreateSurface(tizen_view_->GetRenderTarget(),
-                                       tizen_view_->GetRenderTargetDisplay(),
-                                       geometry.width, geometry.height);
+    TizenViewBase::Geometry geometry =
+        tizen_view_base_->GetRenderTargetGeometry();
+    engine_->renderer()->CreateSurface(
+        tizen_view_base_->GetRenderTarget(),
+        tizen_view_base_->GetRenderTargetDisplay(), geometry.width,
+        geometry.height);
   }
 }
 
@@ -119,16 +121,17 @@ void FlutterTizenView::OnResize(int32_t left,
     std::swap(width, height);
   }
 
-  tizen_view_->ResizeRenderTargetWithRotation({left, top, width, height},
-                                              rotation_degree_);
+  tizen_view_base_->ResizeRenderTargetWithRotation({left, top, width, height},
+                                                   rotation_degree_);
   SendWindowMetrics(left, top, width, height, 0.0);
 }
 
 void FlutterTizenView::OnRotate(int32_t degree) {
   rotation_degree_ = degree;
   // Compute renderer transformation based on the angle of rotation.
   double rad = (360 - rotation_degree_) * M_PI / 180;
-  TizenViewBase::Geometry geometry = tizen_view_->GetRenderTargetGeometry();
+  TizenViewBase::Geometry geometry =
+      tizen_view_base_->GetRenderTargetGeometry();
   int32_t width = geometry.width;
   int32_t height = geometry.height;
 
@@ -152,7 +155,7 @@ void FlutterTizenView::OnRotate(int32_t degree) {
     std::swap(width, height);
   }
 
-  tizen_view_->ResizeRenderTargetWithRotation(
+  tizen_view_base_->ResizeRenderTargetWithRotation(
       {geometry.left, geometry.top, width, height}, rotation_degree_);
 
   // Window position does not change on rotation regardless of its orientation.
@@ -260,11 +263,14 @@ void FlutterTizenView::OnCommit(const std::string& str) {
 }
 
 void FlutterTizenView::SendInitialGeometry() {
-  if (tizen_view_->GetType() == "window") {
-    auto window = reinterpret_cast<TizenWindow*>(tizen_view_.get());
+  if (tizen_view_base_->GetType() == "window") {
+    auto window = reinterpret_cast<TizenWindow*>(tizen_view_base_.get());
     OnRotate(window->GetRotation());
   } else {
-    OnRotate(0);
+    TizenViewBase::Geometry geometry =
+        tizen_view_base_->GetRenderTargetGeometry();
+    SendWindowMetrics(geometry.left, geometry.top, geometry.width,
+                      geometry.height, 0.0);
   }
 }
 
@@ -281,7 +287,7 @@ void FlutterTizenView::SendWindowMetrics(int32_t left,
 #ifdef TV_PROFILE
     double dpi = 72.0;
 #else
-    double dpi = static_cast<double>(tizen_view_->GetDpi());
+    double dpi = static_cast<double>(tizen_view_base_->GetDpi());
 #endif
     double scale_factor = dpi / 90.0 * kProfileFactor;
     computed_pixel_ratio = std::max(scale_factor, 1.0);
@@ -301,7 +307,8 @@ void FlutterTizenView::SendFlutterPointerEvent(
     size_t timestamp,
     FlutterPointerDeviceKind device_kind,
     int device_id) {
-  TizenViewBase::Geometry geometry = tizen_view_->GetRenderTargetGeometry();
+  TizenViewBase::Geometry geometry =
+      tizen_view_base_->GetRenderTargetGeometry();
   double new_x = x, new_y = y;
 
   if (rotation_degree_ == 90) {

shell/platform/tizen/flutter_tizen_view.h

@@ -20,7 +20,7 @@ namespace flutter {
 
 class FlutterTizenView {
  public:
-  FlutterTizenView(std::unique_ptr<TizenViewBase> tizen_view_);
+  FlutterTizenView(std::unique_ptr<TizenViewBase> tizen_view_base_);
 
   ~FlutterTizenView();
 
@@ -30,7 +30,7 @@ class FlutterTizenView {
 
   FlutterTizenEngine* engine() { return engine_.get(); }
 
-  TizenViewBase* tizen_view() { return tizen_view_.get(); }
+  TizenViewBase* tizen_view_base() { return tizen_view_base_.get(); }
 
   // Creates rendering surface for Flutter engine to draw into.
   // Should be called before calling FlutterEngineRun using this view.
@@ -127,7 +127,7 @@ class FlutterTizenView {
   std::unique_ptr<FlutterTizenEngine> engine_;
 
   // The window associated with this view.
-  std::unique_ptr<TizenViewBase> tizen_view_;
+  std::unique_ptr<TizenViewBase> tizen_view_base_;
 
   // The plugin registrar managing internal plugins.
   std::unique_ptr<PluginRegistrar> internal_plugin_registrar_;

shell/platform/tizen/public/flutter_tizen.h

@@ -144,16 +144,19 @@ FLUTTER_EXPORT FlutterDesktopViewRef FlutterDesktopViewCreateFromNewWindow(
     FlutterDesktopEngineRef engine);
 
 // Creates a view that hosts and displays the given engine instance.
+// (@warning: This API is improving. There is no guarantee that exact result.)
 FLUTTER_EXPORT FlutterDesktopViewRef FlutterDesktopViewCreateFromElmParent(
     const FlutterDesktopViewProperties& view_properties,
     FlutterDesktopEngineRef engine,
     void* parent);
 
 // Returns a handle to evas object that the FlutterView is drawn to.
+// (@warning: This API is improving. There is no guarantee that exact result.)
 FLUTTER_EXPORT void* FlutterDesktopViewGetEvasObject(
     FlutterDesktopViewRef view);
 
 // Resize the FlutterView.
+// (@warning: This API is improving. There is no guarantee that exact result.)
 FLUTTER_EXPORT void FlutterDesktopViewResizeView(FlutterDesktopViewRef view,
                                                  int32_t width,
                                                  int32_t height);

shell/platform/tizen/tizen_view_elementary.cc

@@ -316,8 +316,8 @@ void TizenViewElementary::BindKeys(const std::vector<std::string>& keys) {
   // However, it is necessary to bind a special key for each profile(in this
   // case). This part is modified after refactoring related to the key event
   // code.
-  Evas_Object* elm_win = (Evas_Object*)ecore_evas_data_get(
-      ecore_evas_ecore_evas_get(evas_object_evas_get(image_)), "elm_win");
+  Evas_Object* elm_win = static_cast<Evas_Object*>(ecore_evas_data_get(
+      ecore_evas_ecore_evas_get(evas_object_evas_get(image_)), "elm_win"));
   if (elm_win) {
     for (const std::string& key : keys) {
       eext_win_keygrab_set(elm_win, key.c_str());