Fix abstraction level

Author: JSUYA

shell/platform/tizen/tizen_view.h

@@ -16,8 +16,7 @@ class FlutterTizenView;
 
 class TizenView : public TizenViewBase {
  public:
-  TizenView();
-
+  TizenView() = default;
   virtual ~TizenView() = default;
 
   std::string GetType() override { return "view"; };

shell/platform/tizen/tizen_view_base.h

@@ -3,8 +3,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef EMBEDDER_TIZEN_BASE_HANDLE_H_
-#define EMBEDDER_TIZEN_BASE_HANDLE_H_
+#ifndef EMBEDDER_TIZEN_VIEW_BASE_H_
+#define EMBEDDER_TIZEN_VIEW_BASE_H_
 
 #include <cstdint>
 #include <string>
@@ -22,17 +22,16 @@ class TizenViewBase {
     int32_t left = 0, top = 0, width = 0, height = 0;
   };
 
-  TizenViewBase(){};
-
+  TizenViewBase() = default;
   virtual ~TizenViewBase() = default;
 
   // Returns a valid pointer the platform object that rendering can be bound to
   // by rendering backend.
-  virtual void* GetRenderTarget();
+  virtual void* GetRenderTarget() = 0;
 
-  virtual void* GetRenderTargetDisplay();
+  virtual void* GetRenderTargetDisplay() = 0;
 
-  virtual uintptr_t GetWindowId();
+  virtual uintptr_t GetWindowId() = 0;
 
   // Returns the geometry of the current render target.
   virtual Geometry GetRenderTargetGeometry() = 0;
@@ -61,14 +60,19 @@ class TizenViewBase {
 
   virtual void Show() = 0;
 
-  virtual TizenInputMethodContext* input_method_context() = 0;
-
   virtual std::string GetType() = 0;
 
+  TizenInputMethodContext* input_method_context() {
+    return input_method_context_.get();
+  }
+
  protected:
   FlutterTizenView* view_ = nullptr;
+
+  // The Tizen input method context. nullptr if not set.
+  std::unique_ptr<TizenInputMethodContext> input_method_context_;
 };
 
 }  // namespace flutter
 
-#endif  // EMBEDDER_TIZEN_BASE_HANDLE_H_
+#endif  // EMBEDDER_TIZEN_VIEW_BASE_H_

shell/platform/tizen/tizen_view_elementary.h

@@ -45,10 +45,6 @@ class TizenViewElementary : public TizenView {
 
   void OnGeometryChanged(Geometry geometry) override;
 
-  TizenInputMethodContext* input_method_context() override {
-    return input_method_context_.get();
-  }
-
  private:
   bool CreateView();
 
@@ -66,9 +62,6 @@ class TizenViewElementary : public TizenView {
   std::unordered_map<Evas_Callback_Type, Evas_Object_Event_Cb>
       evas_object_callbacks_;
   std::vector<Ecore_Event_Handler*> ecore_event_key_handlers_;
-
-  // The Tizen input method context. nullptr if not set.
-  std::unique_ptr<TizenInputMethodContext> input_method_context_;
 };
 
 }  // namespace flutter

shell/platform/tizen/tizen_window.h

@@ -6,19 +6,19 @@
 #ifndef EMBEDDER_TIZEN_WINDOW_H_
 #define EMBEDDER_TIZEN_WINDOW_H_
 
+#include "flutter/shell/platform/tizen/tizen_view_base.h"
+
 #include <cstdint>
 #include <string>
 #include <vector>
 
-#include "flutter/shell/platform/tizen/tizen_view_base.h"
-
 namespace flutter {
 
 class FlutterTizenView;
 
 class TizenWindow : public TizenViewBase {
  public:
-  TizenWindow();
+  TizenWindow() = default;
   virtual ~TizenWindow() = default;
 
   virtual void* GetWindowHandle();

shell/platform/tizen/tizen_window_ecore_wl2.h

@@ -6,7 +6,6 @@
 #ifndef EMBEDDER_TIZEN_WINDOW_ECORE_WL2_H_
 #define EMBEDDER_TIZEN_WINDOW_ECORE_WL2_H_
 
-#include "flutter/shell/platform/tizen/tizen_view_base.h"
 #include "flutter/shell/platform/tizen/tizen_window.h"
 
 #define EFL_BETA_API_SUPPORT
@@ -53,10 +52,6 @@ class TizenWindowEcoreWl2 : public TizenWindow {
 
   void OnGeometryChanged(Geometry geometry) override;
 
-  TizenInputMethodContext* input_method_context() override {
-    return input_method_context_.get();
-  }
-
  private:
   bool CreateWindow();
 
@@ -82,9 +77,6 @@ class TizenWindowEcoreWl2 : public TizenWindow {
   std::vector<Ecore_Event_Handler*> ecore_event_handlers_;
 
   tizen_policy* tizen_policy_ = nullptr;
-
-  // The Tizen input method context. nullptr if not set.
-  std::unique_ptr<TizenInputMethodContext> input_method_context_;
 };
 
 }  // namespace flutter

shell/platform/tizen/tizen_window_elementary.h

@@ -52,10 +52,6 @@ class TizenWindowElementary : public TizenWindow {
 
   void OnGeometryChanged(Geometry geometry) override;
 
-  TizenInputMethodContext* input_method_context() override {
-    return input_method_context_.get();
-  }
-
  private:
   bool CreateWindow();
 
@@ -75,9 +71,6 @@ class TizenWindowElementary : public TizenWindow {
   Evas_Smart_Cb rotation_changed_callback_;
   std::unordered_map<Evas_Callback_Type, Evas_Object_Event_Cb>
       evas_object_callbacks_;
-
-  // The Tizen input method context. nullptr if not set.
-  std::unique_ptr<TizenInputMethodContext> input_method_context_;
 };
 
 }  // namespace flutter