resource_kubelet_pool: improvements #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invidian
force-pushed
the
kubelet-terraform
branch
from
fa5ca27 to
64ac97c
Compare
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
+ Coverage 85.62% 86.88% +1.26%
==========================================
Files 64 65 +1
Lines 3234 3318 +84
==========================================
+ Hits 2769 2883 +114
+ Misses 352 318 -34
- Partials 113 117 +4
Continue to review full report at Codecov.
|
As deserialized previous state won't have them. Signed-off-by: Mateusz Gozdek <[email protected]>
This commit adds some general improvements to kubelet code, adds back omitempty tags, as now Terraform does serialize the configuration, changes CA Certificate type from string to types.Certificate and validates that name is not empty, as otherwise labels cannot be applied to the node. Signed-off-by: Mateusz Gozdek <[email protected]>
Signed-off-by: Mateusz Gozdek <[email protected]>
Signed-off-by: Mateusz Gozdek <[email protected]>
invidian
force-pushed
the
kubelet-terraform
branch
from
64ac97c to
e8de3b8
Compare
|
Code Climate has analyzed commit e8de3b8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 92.1% (50% is the threshold). This pull request will bring the total coverage in the repository to 86.0% (1.5% change). View more on Code Climate. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.