refactor(utils)!: [isNumber] check typeof value

Signed-off-by: Lexus Drumgold <[email protected]>

Author: unicornware

src/utils/__tests__/is-number.spec.ts

@@ -13,7 +13,6 @@ describe('unit:utils/isNumber', () => {
     const cases: Parameters<typeof testSubject>[] = [
       [[INTEGER]],
       [Symbol('is-number')],
-      [Number.NaN],
       [faker.string.numeric()]
     ]
 
@@ -23,7 +22,11 @@ describe('unit:utils/isNumber', () => {
 
   it('should return true if value is a number', () => {
     // Arrange
-    const cases: Parameters<typeof testSubject>[] = [[FLOAT], [INTEGER]]
+    const cases: Parameters<typeof testSubject>[] = [
+      [FLOAT],
+      [INTEGER],
+      [Number.NaN]
+    ]
 
     // Act + Expect
     cases.forEach(([value]) => expect(testSubject(value)).to.be.true)

src/utils/is-nan.ts

@@ -3,7 +3,7 @@
  * @module tutils/utils/isNaN
  */
 
-import equal from './equal'
+import isNumber from './is-number'
 
 /**
  * Checks if `value` is {@linkcode Number.NaN}.
@@ -13,6 +13,6 @@ import equal from './equal'
  * @param {unknown} value - Value to check
  * @return {boolean} `true` if `value` is `Number.NaN`
  */
-const isNaN = (value: unknown): boolean => equal(Number.NaN, value)
+const isNaN = (value: unknown): boolean => isNumber(value) && value !== +value
 
 export default isNaN

src/utils/is-number.ts

@@ -11,12 +11,6 @@
  * @param {unknown} value - Value to check
  * @return {value is number} `true` if `value` is a number
  */
-const isNumber = (value: unknown): value is number => {
-  try {
-    return Number(value) === value
-  } catch {
-    return false
-  }
-}
+const isNumber = (value: unknown): value is number => typeof value === 'number'
 
 export default isNumber

src/utils/is-numeric.ts

@@ -4,6 +4,7 @@
  */
 
 import type { Numeric } from '#src/types'
+import isNaN from './is-nan'
 import isNumber from './is-number'
 import isString from './is-string'
 
@@ -19,7 +20,7 @@ import isString from './is-string'
  * @return {value is Numeric} `true` if `value` is a numeric
  */
 const isNumeric = (value: unknown): value is Numeric => {
-  return isString(value) && isNumber(+value)
+  return isString(value) && isNumber((value = +value)) && !isNaN(value)
 }
 
 export default isNumeric