refactor(core): signInWithOAuth -> signInWithProvider

Author: Ehesp

packages/core/src/auth.ts

@@ -213,7 +213,7 @@ export async function signInAnonymously(ui: FirebaseUIConfiguration): Promise<Us
   }
 }
 
-export async function signInWithOAuth(ui: FirebaseUIConfiguration, provider: AuthProvider): Promise<void> {
+export async function signInWithProvider(ui: FirebaseUIConfiguration, provider: AuthProvider): Promise<void> {
   try {
     if (hasBehavior(ui, "autoUpgradeAnonymousProvider")) {
       await getBehavior(ui, "autoUpgradeAnonymousProvider")(ui, provider);
@@ -222,6 +222,8 @@ export async function signInWithOAuth(ui: FirebaseUIConfiguration, provider: Aut
     }
 
     ui.setState("pending");
+
+    // TODO(ehesp): Handle popup or redirect based on behavior
     await signInWithRedirect(ui.auth, provider);
     // We don't modify state here since the user is redirected.
     // If we support popups, we'd need to modify state here.

packages/core/tests/unit/auth.test.ts

@@ -41,7 +41,7 @@ import {
   sendSignInLinkToEmail,
   signInWithEmailLink,
   signInAnonymously,
-  signInWithOAuth,
+  signInWithProvider,
   completeEmailLinkSignIn,
 } from "../../src/auth";
 import { FirebaseUIConfiguration } from "../../src/config";
@@ -302,11 +302,11 @@ describe("Firebase UI Auth", () => {
     });
   });
 
-  describe("signInWithOAuth", () => {
+  describe("signInWithProvider", () => {
     it("should sign in with OAuth provider", async () => {
       (signInWithRedirect as any).mockResolvedValue(undefined);
 
-      await signInWithOAuth(mockUi, mockProvider as any);
+      await signInWithProvider(mockUi, mockProvider as any);
 
       expect(signInWithRedirect).toHaveBeenCalledWith(mockAuth, mockProvider);
     });
@@ -318,7 +318,7 @@ describe("Firebase UI Auth", () => {
 
       mockUi.behaviors.autoUpgradeAnonymousProvider = vi.fn();
 
-      await signInWithOAuth(mockUi, mockProvider as any);
+      await signInWithProvider(mockUi, mockProvider as any);
 
       expect(mockUi.behaviors.autoUpgradeAnonymousProvider).toHaveBeenCalledWith(mockUi, mockProvider);
     });