From a02cc2c75a78535d02a0a1fd4f6eefdf91a93ba4 Mon Sep 17 00:00:00 2001 From: Sairam Sakhamuri Date: Wed, 1 Nov 2023 14:36:12 +0000 Subject: [PATCH 1/6] Change name from stack to backend --- src/commands/frameworks-stacks-create.ts | 4 ++-- src/commands/frameworks-stacks-delete.ts | 20 ++++++++++---------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/commands/frameworks-stacks-create.ts b/src/commands/frameworks-stacks-create.ts index 5ffe85a9c12..b31b5033820 100644 --- a/src/commands/frameworks-stacks-create.ts +++ b/src/commands/frameworks-stacks-create.ts @@ -4,8 +4,8 @@ import { needProjectId } from "../projectUtils"; import requireInteractive from "../requireInteractive"; import { doSetup } from "../init/features/frameworks"; -export const command = new Command("stacks:create") - .description("Create a stack in a Firebase project") +export const command = new Command("backends:create") + .description("Create a backend in a Firebase project") .before(requireInteractive) .action(async (options: Options) => { const projectId = needProjectId(options); diff --git a/src/commands/frameworks-stacks-delete.ts b/src/commands/frameworks-stacks-delete.ts index 8916e856b10..722b8fdc7d4 100644 --- a/src/commands/frameworks-stacks-delete.ts +++ b/src/commands/frameworks-stacks-delete.ts @@ -6,24 +6,24 @@ import * as gcp from "../gcp/frameworks"; import { promptOnce } from "../prompt"; import * as utils from "../utils"; -export const command = new Command("stacks:delete") - .description("Delete a stack from a Firebase project") +export const command = new Command("backends:delete") + .description("Delete a backend from a Firebase project") .option("-l, --location ", "App Backend location", "us-central1") - .option("-s, --stackId ", "Stack Id", "") + .option("-s, --backendId ", "Backend Id", "") .withForce() .action(async (options: Options) => { const projectId = needProjectId(options); const location = options.location as string; - const stackId = options.stackId as string; - if (!stackId) { - throw new FirebaseError("Stack id can't be empty."); + const backendId = options.backendId as string; + if (!backendId) { + throw new FirebaseError("Backend id can't be empty."); } const confirmDeletion = await promptOnce( { type: "confirm", name: "force", default: false, - message: "You are about to delete the Stack with id: " + stackId + "\n Are you sure?", + message: "You are about to delete the Backend with id: " + backendId + "\n Are you sure?", }, options ); @@ -32,11 +32,11 @@ export const command = new Command("stacks:delete") } try { - await gcp.deleteStack(projectId, location, stackId); - utils.logSuccess(`Successfully deleted the stack: ${stackId}`); + await gcp.deleteStack(projectId, location, backendId); + utils.logSuccess(`Successfully deleted the backend: ${backendId}`); } catch (err: any) { throw new FirebaseError( - `Failed to delete stack: ${stackId}. Please check the parameters you have provided.`, + `Failed to delete backend: ${backendId}. Please check the parameters you have provided.`, { original: err } ); } From 000a270043a556ad0c3ce492971efba43b813faf Mon Sep 17 00:00:00 2001 From: Sairam Sakhamuri Date: Wed, 1 Nov 2023 14:41:33 +0000 Subject: [PATCH 2/6] Change name from stack to backend --- src/commands/frameworks-stacks-delete.ts | 2 +- src/gcp/frameworks.ts | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/commands/frameworks-stacks-delete.ts b/src/commands/frameworks-stacks-delete.ts index 722b8fdc7d4..6d912d5a2dd 100644 --- a/src/commands/frameworks-stacks-delete.ts +++ b/src/commands/frameworks-stacks-delete.ts @@ -32,7 +32,7 @@ export const command = new Command("backends:delete") } try { - await gcp.deleteStack(projectId, location, backendId); + await gcp.deleteBackend(projectId, location, backendId); utils.logSuccess(`Successfully deleted the backend: ${backendId}`); } catch (err: any) { throw new FirebaseError( diff --git a/src/gcp/frameworks.ts b/src/gcp/frameworks.ts index cc7f3a5f4d2..1523ba36cba 100644 --- a/src/gcp/frameworks.ts +++ b/src/gcp/frameworks.ts @@ -128,14 +128,14 @@ export async function listStack(projectId: string, location: string): Promise
  • { - const name = `projects/${projectId}/locations/${location}/backends/${stackId}`; + const name = `projects/${projectId}/locations/${location}/backends/${backendId}`; const res = await client.delete(name); return res.body; From 12e8ae527ad85f4d5950efaec8d8cafbad65d1b1 Mon Sep 17 00:00:00 2001 From: Sairam Sakhamuri Date: Wed, 1 Nov 2023 17:27:04 +0000 Subject: [PATCH 3/6] changed file names --- ...{frameworks-stacks-create.ts => frameworks-backends-create.ts} | 0 ...{frameworks-stacks-delete.ts => frameworks-backends-delete.ts} | 0 2 files changed, 0 insertions(+), 0 deletions(-) rename src/commands/{frameworks-stacks-create.ts => frameworks-backends-create.ts} (100%) rename src/commands/{frameworks-stacks-delete.ts => frameworks-backends-delete.ts} (100%) diff --git a/src/commands/frameworks-stacks-create.ts b/src/commands/frameworks-backends-create.ts similarity index 100% rename from src/commands/frameworks-stacks-create.ts rename to src/commands/frameworks-backends-create.ts diff --git a/src/commands/frameworks-stacks-delete.ts b/src/commands/frameworks-backends-delete.ts similarity index 100% rename from src/commands/frameworks-stacks-delete.ts rename to src/commands/frameworks-backends-delete.ts From 8a433262a2d04576d052caa05a9673e32f0c8618 Mon Sep 17 00:00:00 2001 From: Sairam Sakhamuri Date: Wed, 1 Nov 2023 17:27:34 +0000 Subject: [PATCH 4/6] changed file names in experiments --- src/commands/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/commands/index.ts b/src/commands/index.ts index 4814d4f66fe..cf22615a910 100644 --- a/src/commands/index.ts +++ b/src/commands/index.ts @@ -155,9 +155,9 @@ export function load(client: any): any { client.frameworks = {}; client.frameworks.stacks = {}; client.frameworks.stacks.list = loadCommand("frameworks-stacks-list"); - client.frameworks.stacks.create = loadCommand("frameworks-stacks-create"); + client.frameworks.stacks.create = loadCommand("frameworks-backends-create"); client.frameworks.stacks.create = loadCommand("frameworks-stacks-get"); - client.frameworks.stacks.create = loadCommand("frameworks-stacks-delete"); + client.frameworks.stacks.create = loadCommand("frameworks-backends-delete"); } client.login = loadCommand("login"); client.login.add = loadCommand("login-add"); From 3fb49b4367a88a8c0b5bf5e32a8baf3a8ef51d25 Mon Sep 17 00:00:00 2001 From: Sairam Sakhamuri Date: Wed, 1 Nov 2023 19:34:50 +0000 Subject: [PATCH 5/6] changed name --- src/commands/frameworks-backends-delete.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/commands/frameworks-backends-delete.ts b/src/commands/frameworks-backends-delete.ts index 6d912d5a2dd..21c79a993f4 100644 --- a/src/commands/frameworks-backends-delete.ts +++ b/src/commands/frameworks-backends-delete.ts @@ -23,7 +23,7 @@ export const command = new Command("backends:delete") type: "confirm", name: "force", default: false, - message: "You are about to delete the Backend with id: " + backendId + "\n Are you sure?", + message: "You are about to delete the backend with id: " + backendId + "\n Are you sure?", }, options ); From 272d0e0f2e9efb11acb5b8e47afe0477c22030b8 Mon Sep 17 00:00:00 2001 From: Sairam Sakhamuri Date: Wed, 1 Nov 2023 20:10:42 +0000 Subject: [PATCH 6/6] lower case backend --- src/gcp/frameworks.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gcp/frameworks.ts b/src/gcp/frameworks.ts index 1523ba36cba..b6d740074e9 100644 --- a/src/gcp/frameworks.ts +++ b/src/gcp/frameworks.ts @@ -128,7 +128,7 @@ export async function listStack(projectId: string, location: string): Promise