From 0d75b9f8087b4aced2d060eaeb993aacc49a6b30 Mon Sep 17 00:00:00 2001 From: Brian Li Date: Wed, 11 Oct 2023 11:38:29 -0400 Subject: [PATCH 1/3] do not read firestore emulator env var on deploy --- src/gcp/firestore.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gcp/firestore.ts b/src/gcp/firestore.ts index 2d3a3d7b82b..e5897c75f66 100644 --- a/src/gcp/firestore.ts +++ b/src/gcp/firestore.ts @@ -1,11 +1,11 @@ -import { firestoreOriginOrEmulator } from "../api"; +import { firestoreOrigin } from "../api"; import { Client } from "../apiv2"; import { logger } from "../logger"; const apiClient = new Client({ auth: true, apiVersion: "v1", - urlPrefix: firestoreOriginOrEmulator, + urlPrefix: firestoreOrigin, }); interface Database { From 4b35581fd8544c2cb25f48aae19dd6f6ff167e10 Mon Sep 17 00:00:00 2001 From: Brian Li Date: Wed, 11 Oct 2023 11:43:09 -0400 Subject: [PATCH 2/3] update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 564b82f756c..e9cbc7b3f24 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1 +1,2 @@ +- Ignore Firestore emulator host on functions deploy. (#6442) - Added support for enabling, disabling, and displaying Point In Time Recovery enablement state on Firestore databases (#6388) From 35a610442de0b3b7d8e909c935e41f535281e564 Mon Sep 17 00:00:00 2001 From: joehan Date: Wed, 11 Oct 2023 11:05:23 -0700 Subject: [PATCH 3/3] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e9cbc7b3f24..9f8678351fa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,2 +1,2 @@ -- Ignore Firestore emulator host on functions deploy. (#6442) +- Ignore `FIRESTORE_EMULATOR_HOST` environment variable on functions deploy. (#6442) - Added support for enabling, disabling, and displaying Point In Time Recovery enablement state on Firestore databases (#6388)