Skip to content

emulators:exec support for Storage emulator #3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2021
Merged

emulators:exec support for Storage emulator #3337

merged 1 commit into from
May 6, 2021

Conversation

@samtstern
Copy link
Contributor

@samtstern samtstern commented May 6, 2021

Description

Make emulators:exec set the storage emulator environment variables.

Scenarios Tested

$ firebase emulators:exec 'echo $FIREBASE_STORAGE_EMULATOR_HOST; echo $STORAGE_EMULATOR_HOST'
i  emulators: Starting emulators: storage
i  Running script: echo $FIREBASE_STORAGE_EMULATOR_HOST; echo $STORAGE_EMULATOR_HOST
localhost:9199
http://localhost:9199
✔  Script exited successfully (code 0)
i  emulators: Shutting down emulators.
i  storage: Stopping Storage Emulator
i  hub: Stopping emulator hub

Sample Commands

N/A

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label May 6, 2021
@samtstern samtstern requested review from abeisgoat and yuchenshi May 6, 2021 09:31
@samtstern samtstern mentioned this pull request May 6, 2021
Merged
4 tasks
@yuchenshi yuchenshi merged commit 0fcaf5d into master May 6, 2021
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
@samtstern @devpeerapong
emulators:exec support for Storage emulator (firebase#3337)
f1ecdc1
@bkendall bkendall deleted the ss-storage-emulators-exec branch March 18, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@abeisgoat abeisgoat Awaiting requested review from abeisgoat

Assignees

@abeisgoat abeisgoat

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samtstern @yuchenshi @abeisgoat