PR feedback

Author: inlined

src/deploy/functions/runtimes/golang/index.ts

@@ -130,8 +130,7 @@ export class Delegate {
     private readonly module: Module
   ) {}
   validate(): Promise<void> {
-    // throw new FirebaseError("Cannot yet analyze Go source code");
-    return Promise.resolve();
+    throw new FirebaseError("Cannot yet analyze Go source code");
   }
 
   build(): Promise<void> {
@@ -155,25 +154,6 @@ export class Delegate {
     configValues: backend.RuntimeConfigValues,
     envs: backend.EnvironmentVariables
   ): Promise<backend.Backend> {
-    const stubbed: backend.Backend = {
-      requiredAPIs: {},
-      topics: [],
-      schedules: [],
-      cloudFunctions: [
-        {
-          apiVersion: 1,
-          id: "HelloWorld",
-          region: "us-central1",
-          project: this.projectId,
-          entryPoint: "HelloWorld",
-          runtime: this.runtime,
-          trigger: {
-            allowInsecure: false,
-          },
-        },
-      ],
-      environmentVariables: envs,
-    };
-    return Promise.resolve(stubbed);
+    throw new FirebaseError("Cannot yet discover function specs");
   }
 }

src/deploy/functions/runtimes/index.ts

@@ -7,8 +7,12 @@ import * as validate from "../validate";
 import { FirebaseError } from "../../../error";
 
 /** Supported runtimes for new Cloud Functions. */
-const RUNTIMES: string[] = ["nodejs10", "nodejs12", "nodejs14", "go113"];
-export type Runtime = typeof RUNTIMES[number];
+const RUNTIMES: string[] = ["nodejs10", "nodejs12", "nodejs14"]
+// Experimental runtimes are part of the Runtime type, but are in a
+// different list to help guard against some day accidentally iterating over
+// and printing a hidden runtime to the user.
+const EXPERIMENTAL_RUNTIMES = ["go113"];
+export type Runtime = typeof RUNTIMES[number] | typeof EXPERIMENTAL_RUNTIMES[number];
 
 /** Runtimes that can be found in existing backends but not used for new functions. */
 const DEPRECATED_RUNTIMES = ["nodejs6", "nodejs8"];
@@ -21,7 +25,7 @@ export function isDeprecatedRuntime(runtime: string): runtime is DeprecatedRunti
 
 /** Type deduction helper for a runtime string. */
 export function isValidRuntime(runtime: string): runtime is Runtime {
-  return RUNTIMES.includes(runtime);
+  return RUNTIMES.includes(runtime) || EXPERIMENTAL_RUNTIMES.includes(runtime);
 }
 
 const MESSAGE_FRIENDLY_RUNTIMES: Record<Runtime | DeprecatedRuntime, string> = {

src/init/features/functions/golang.ts

@@ -96,9 +96,6 @@ async function writeModFile(config: Config) {
   const extractArchive = unzipper.Extract({ path: config.path("functions/firebase-functions-go") });
   await promisify(stream.pipeline)(download.body, extractArchive);
 
-  // Should this come later as "would you like to install dependencies" to mirror Node?
-  // It's less clearly distinct from node where you can edit the package.json file w/o installing.
-  // Here we're actually locking in a version in go.mod _and_ installing it in one step.
   const result = spawn.sync("go", ["get", ADMIN_SDK], {
     cwd: config.path("functions"),
     stdio: "inherit",

templates/init/functions/golang/_gitignore

@@ -9,4 +9,4 @@
 *.test
 
 # Output of the go coverage tool, specifically when used with LiteIDE
-*.out
+*.out