implement no-authorized-domains for channels:deploy (#3741)

* implement no-authorized-domains for channels:deploy

* changelog

* spacing is important

* FORMATTING IS HARD

Author: bkendall

CHANGELOG.md

@@ -1,2 +1,3 @@
 - `ext:install` now supports `--force` and `--non-interactive` flags.
 - Fixes a crash when customers deploy an empty Cloud Functions project (#3705)
+- Fixes (and implements) `--no-authorized-domains`, skipping syncing with Firebase Auth, when deploying to a Firebase Hosting channel (#3740).

src/commands/hosting-channel-deploy.ts

@@ -55,10 +55,6 @@ export default new Command("hosting:channel:deploy [channelId]")
       if (options.open) {
         throw new FirebaseError("open is not yet implemented");
       }
-      // TODO: implement --no-authorized-domains.
-      if (options["no-authorized-domains"]) {
-        throw new FirebaseError("no-authorized-domains is not yet implemented");
-      }
 
       let expireTTL = DEFAULT_DURATION;
       if (options.expires) {
@@ -151,8 +147,15 @@ export default new Command("hosting:channel:deploy [channelId]")
         });
       }
 
+      if (options.authorizedDomains) {
+        await syncAuthState(projectId, sites);
+      } else {
+        logger.debug(
+          `skipping syncAuthState since authorizedDomains is ${options.authorizedDomains}`
+        );
+      }
+
       logger.info();
-      await syncAuthState(projectId, sites);
       const deploys: { [key: string]: ChannelInfo } = {};
       sites.forEach((d) => {
         deploys[d.target || d.site] = d;