From ec516fba7b5b672093c98dd24569a8e145c1ce6e Mon Sep 17 00:00:00 2001 From: Wu-Hui Date: Thu, 17 Aug 2023 16:48:15 -0400 Subject: [PATCH 1/2] Fix how we enable fetch streams. --- .../firestore/src/platform/browser/webchannel_connection.ts | 3 +-- packages/webchannel-wrapper/src/index.d.ts | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/firestore/src/platform/browser/webchannel_connection.ts b/packages/firestore/src/platform/browser/webchannel_connection.ts index 5082418cf69..05cd79ecf9e 100644 --- a/packages/firestore/src/platform/browser/webchannel_connection.ts +++ b/packages/firestore/src/platform/browser/webchannel_connection.ts @@ -22,7 +22,6 @@ import { WebChannel, WebChannelError, WebChannelOptions, - FetchXmlHttpFactory, XhrIo, getStatEventTarget, EventTarget, @@ -209,7 +208,7 @@ export class WebChannelConnection extends RestConnection { } if (this.useFetchStreams) { - request.xmlHttpFactory = new FetchXmlHttpFactory({}); + request.useFetchStreams = true; } this.modifyHeadersForRequest( diff --git a/packages/webchannel-wrapper/src/index.d.ts b/packages/webchannel-wrapper/src/index.d.ts index 007287a5d9e..776bb8e8634 100644 --- a/packages/webchannel-wrapper/src/index.d.ts +++ b/packages/webchannel-wrapper/src/index.d.ts @@ -108,6 +108,7 @@ export interface WebChannelOptions { internalChannelParams?: { forwardChannelRequestTimeoutMs?: number; }; + useFetchStreams?: boolean; xmlHttpFactory?: unknown; requestRefreshThresholds?: { [key: string]: number }; } From 47cc39effa95991140469a04165ce3a8f78d95a6 Mon Sep 17 00:00:00 2001 From: wu-hui <53845758+wu-hui@users.noreply.github.com> Date: Thu, 17 Aug 2023 17:17:21 -0400 Subject: [PATCH 2/2] Create nervous-cups-relax.md --- .changeset/nervous-cups-relax.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/nervous-cups-relax.md diff --git a/.changeset/nervous-cups-relax.md b/.changeset/nervous-cups-relax.md new file mode 100644 index 00000000000..1b307f4a3b8 --- /dev/null +++ b/.changeset/nervous-cups-relax.md @@ -0,0 +1,6 @@ +--- +"@firebase/firestore": patch +"@firebase/webchannel-wrapper": patch +--- + +Fix how we enable fetch streams.