Skip to content

Conversation

@NhienLam
Copy link
Contributor

@NhienLam NhienLam commented Aug 9, 2023

Implement revokeAccessToken public api.

Note:
-Did not add tests to auth_impl.test.ts because backend doesn’t return anything for revokeToken api and we cannot verify if apple oauth access token is revoked in auth_impl.test.ts. Please let me know if I’m wrong or there are ways to test auth_impl#revokeAccessToken.
-Tested with demo app and was able to revoke apple oauth access token. However, wasn't able to test in multi-tenancy environment because firebase test project doesn't support multi-tenancy and I don't have a personal project that has Apply sign in provider set up.

TODO: Write integration tests if we can retrieve the apple oauth access token in the testing environment.

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023

⚠️ No Changeset found

Latest commit: d72ccbc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@NhienLam NhienLam requested review from bhparijat and removed request for a team, dwyfrequency, hsubox76, lisajian and sam-gc August 9, 2023 19:15
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 9, 2023

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (f73b24d)Merge (0915849)Diff
    browser177 kB177 kB+559 B (+0.3%)
    cordova206 kB206 kB+875 B (+0.4%)
    esm5231 kB231 kB+875 B (+0.4%)
    main175 kB176 kB+1.02 kB (+0.6%)
    module177 kB177 kB+559 B (+0.3%)
    react-native189 kB190 kB+1.03 kB (+0.5%)
  • @firebase/auth/cordova

    TypeBase (f73b24d)Merge (0915849)Diff
    browser206 kB206 kB+875 B (+0.4%)
    module206 kB206 kB+875 B (+0.4%)
  • @firebase/auth/internal

    TypeBase (f73b24d)Merge (0915849)Diff
    browser188 kB188 kB+559 B (+0.3%)
    esm5244 kB245 kB+875 B (+0.4%)
    main211 kB212 kB+1.03 kB (+0.5%)
    module188 kB188 kB+559 B (+0.3%)
  • bundle

    TypeBase (f73b24d)Merge (0915849)Diff
    auth (Anonymous)72.6 kB72.9 kB+313 B (+0.4%)
    auth (EmailAndPassword)79.9 kB80.2 kB+313 B (+0.4%)
    auth (GoogleFBTwitterGitHubPopup)99.2 kB99.5 kB+313 B (+0.3%)
    auth (GooglePopup)96.5 kB96.8 kB+313 B (+0.3%)
    auth (GoogleRedirect)96.7 kB97.0 kB+313 B (+0.3%)
    auth (Phone)82.9 kB83.2 kB+313 B (+0.4%)
  • firebase

    TypeBase (f73b24d)Merge (0915849)Diff
    firebase-auth-compat.js136 kB137 kB+277 B (+0.2%)
    firebase-auth-cordova.js174 kB175 kB+745 B (+0.4%)
    firebase-auth.js147 kB147 kB+432 B (+0.3%)
    firebase-compat.js778 kB778 kB+277 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fwcMiMTtcs.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 9, 2023

Size Analysis Report 1

This report is too large (248,751 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/3XTXe1qTjF.html

@NhienLam NhienLam merged commit c149359 into token-revoke Aug 10, 2023
@NhienLam NhienLam deleted the nhienlam-patch branch August 10, 2023 21:45
@firebase firebase locked and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants