From da32d736c8c2a54e2ebb0c67a2f8a23ed20d8543 Mon Sep 17 00:00:00 2001 From: Michael Lehenbauer Date: Wed, 25 Apr 2018 14:30:45 -0700 Subject: [PATCH] Use correct assert() method so we get good error messages. BEFORE: AssertionError: expected null to roughly deeply equal undefined AFTER: AssertionError: expected { Object (elements) } to roughly deeply equal { Object (elements) } + expected - actual { "elements": [ { - "internalValue": "foo" + "internalValue": "tag" "typeOrder": 4 } ] } --- packages/firestore/test/util/equality_matcher.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/firestore/test/util/equality_matcher.ts b/packages/firestore/test/util/equality_matcher.ts index fde942c1c66..5eaca68d319 100644 --- a/packages/firestore/test/util/equality_matcher.ts +++ b/packages/firestore/test/util/equality_matcher.ts @@ -71,13 +71,13 @@ export function addEqualityMatcher(): void { utils.flag(this, 'message', msg); const left = utils.flag(this, 'object'); - chai.assert( + new chai.Assertion(left).assert( customDeepEqual(left, right), 'expected #{act} to roughly deeply equal #{exp}', 'expected #{act} to not roughly deeply equal #{exp}', left, right, - true + /*showDiff=*/ true ); } else { originalFunction.apply(this, args);