Skip to content

Firestore: settings.ts: very minor refactor of long-polling logic. #7239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 21, 2023
Merged

Firestore: settings.ts: very minor refactor of long-polling logic. #7239

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
eb854dc
Firestore: settings.ts: very minor refactor of long-polling logic.
dconeybe Apr 20, 2023
ef8665f
invert negative 'if' statement and ensure that experimentalAutoDetect…
dconeybe Apr 20, 2023
8e84d43
add DEFAULT_AUTO_DETECT_LONG_POLLING and coerce to boolean
dconeybe Apr 20, 2023
3e2be99
Firestore: database.test.ts: add tests for coercing experimentalForce…
dconeybe Apr 20, 2023
d8fccbe
yarn prettier
dconeybe Apr 20, 2023
7427858
tweak unit test descriptions
dconeybe Apr 20, 2023
81a61b4
add `// eslint-disable-next-line @typescript-eslint/no-explicit-any` …
dconeybe Apr 20, 2023
10aba36
Merge branch 'LongPollingCoerceToBooleanTests' into LongPollingLogicT…
dconeybe Apr 20, 2023
17519c3
invert a negative 'if' statement
dconeybe Apr 20, 2023
c27a49a
Merge remote-tracking branch 'origin/master' into LongPollingLogicTweak
dconeybe Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions packages/firestore/src/lite-api/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ import { validateIsNotUsedTogether } from '../util/input_validation';
export const DEFAULT_HOST = 'firestore.googleapis.com';
export const DEFAULT_SSL = true;

const DEFAULT_AUTO_DETECT_LONG_POLLING = false;

/**
* Specifies custom configurations for your Cloud Firestore instance.
* You must set these before invoking any other methods.
Expand Down Expand Up @@ -123,17 +125,28 @@ export class FirestoreSettingsImpl {
}
}

this.experimentalForceLongPolling = !!settings.experimentalForceLongPolling;
this.experimentalAutoDetectLongPolling =
!!settings.experimentalAutoDetectLongPolling;
this.useFetchStreams = !!settings.useFetchStreams;

validateIsNotUsedTogether(
'experimentalForceLongPolling',
settings.experimentalForceLongPolling,
'experimentalAutoDetectLongPolling',
settings.experimentalAutoDetectLongPolling
);

this.experimentalForceLongPolling = !!settings.experimentalForceLongPolling;

if (this.experimentalForceLongPolling) {
this.experimentalAutoDetectLongPolling = false;
} else if (settings.experimentalAutoDetectLongPolling === undefined) {
this.experimentalAutoDetectLongPolling = DEFAULT_AUTO_DETECT_LONG_POLLING;
} else {
// For backwards compatibility, coerce the value to boolean even though
// the TypeScript compiler has narrowed the type to boolean already.
// noinspection PointlessBooleanExpressionJS
this.experimentalAutoDetectLongPolling =
!!settings.experimentalAutoDetectLongPolling;
}

this.useFetchStreams = !!settings.useFetchStreams;
}

isEqual(other: FirestoreSettingsImpl): boolean {
Expand Down