From 5b46d3ede90a61dc731b285b187e14db7ab46f4d Mon Sep 17 00:00:00 2001 From: nhienlam Date: Thu, 6 Apr 2023 13:59:59 -0700 Subject: [PATCH 1/4] Pin chrome stable version 112 --- .github/workflows/test-changed-auth.yml | 6 +++++- packages/auth/src/api/authentication/email_link.ts | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test-changed-auth.yml b/.github/workflows/test-changed-auth.yml index 470c44e9aa9..72c6c5da84c 100644 --- a/.github/workflows/test-changed-auth.yml +++ b/.github/workflows/test-changed-auth.yml @@ -14,9 +14,13 @@ jobs: steps: # install Chrome first, so the correct version of webdriver can be installed by chromedriver when setting up the repo - name: install Chrome stable + # Install Chrome version 112.0.5615.49 as test starts to fail on version 111. + # We will unpin, once version 112 becomes stable. run: | sudo apt-get update - sudo apt-get install google-chrome-stable + sudo apt-get install wget + sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_112.0.5615.49_amd64.deb + sudo apt-get install -f ./google-chrome-stable_112.0.5615.49_amd64.deb --allow-downgrades - name: Checkout Repo uses: actions/checkout@master with: diff --git a/packages/auth/src/api/authentication/email_link.ts b/packages/auth/src/api/authentication/email_link.ts index bae82634abd..ccaacf17c6d 100644 --- a/packages/auth/src/api/authentication/email_link.ts +++ b/packages/auth/src/api/authentication/email_link.ts @@ -30,6 +30,7 @@ export interface SignInWithEmailLinkRequest { tenantId?: string; } +// add a comment to trigger packages/auth CI tests export interface SignInWithEmailLinkResponse extends IdTokenResponse { email: string; isNewUser: boolean; From c1b1648e04eb794537aab101302815fadb9420b2 Mon Sep 17 00:00:00 2001 From: nhienlam Date: Thu, 6 Apr 2023 14:06:14 -0700 Subject: [PATCH 2/4] Try with unstable version 112 --- .github/workflows/test-changed-auth.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test-changed-auth.yml b/.github/workflows/test-changed-auth.yml index 72c6c5da84c..aed995995a3 100644 --- a/.github/workflows/test-changed-auth.yml +++ b/.github/workflows/test-changed-auth.yml @@ -14,13 +14,13 @@ jobs: steps: # install Chrome first, so the correct version of webdriver can be installed by chromedriver when setting up the repo - name: install Chrome stable - # Install Chrome version 112.0.5615.49 as test starts to fail on version 111. + # Install Chrome unstable version 112.0.5615.49 as test starts to fail on version 111. # We will unpin, once version 112 becomes stable. run: | sudo apt-get update sudo apt-get install wget - sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_112.0.5615.49_amd64.deb - sudo apt-get install -f ./google-chrome-stable_112.0.5615.49_amd64.deb --allow-downgrades + sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-unstable_112.0.5615.49_amd64.deb + sudo apt-get install -f ./google-chrome-unstable_112.0.5615.49_amd64.deb --allow-downgrades - name: Checkout Repo uses: actions/checkout@master with: From 51c10320791caf7d0cb5321470a7bfeb44368ca4 Mon Sep 17 00:00:00 2001 From: nhienlam Date: Thu, 6 Apr 2023 14:12:46 -0700 Subject: [PATCH 3/4] Pin Chrome version 110.0.5481.177-1 --- .github/workflows/test-changed-auth.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test-changed-auth.yml b/.github/workflows/test-changed-auth.yml index aed995995a3..90b057f72fd 100644 --- a/.github/workflows/test-changed-auth.yml +++ b/.github/workflows/test-changed-auth.yml @@ -14,13 +14,13 @@ jobs: steps: # install Chrome first, so the correct version of webdriver can be installed by chromedriver when setting up the repo - name: install Chrome stable - # Install Chrome unstable version 112.0.5615.49 as test starts to fail on version 111. - # We will unpin, once version 112 becomes stable. + # Install Chrome version 110.0.5481.177-1 as test starts to fail on version 111. + # We will retry to use the latest, once version 112 becomes stable. run: | sudo apt-get update sudo apt-get install wget - sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-unstable_112.0.5615.49_amd64.deb - sudo apt-get install -f ./google-chrome-unstable_112.0.5615.49_amd64.deb --allow-downgrades + sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_110.0.5481.177-1_amd64.deb + sudo apt-get install -f ./google-chrome-stable_110.0.5481.177-1_amd64.deb --allow-downgrades - name: Checkout Repo uses: actions/checkout@master with: From 33ed31a7f0e3dc9e9155ff62eaba3d1db6a5a7c8 Mon Sep 17 00:00:00 2001 From: nhienlam Date: Thu, 6 Apr 2023 15:35:48 -0700 Subject: [PATCH 4/4] remove a dummy change --- packages/auth/src/api/authentication/email_link.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/auth/src/api/authentication/email_link.ts b/packages/auth/src/api/authentication/email_link.ts index ccaacf17c6d..bae82634abd 100644 --- a/packages/auth/src/api/authentication/email_link.ts +++ b/packages/auth/src/api/authentication/email_link.ts @@ -30,7 +30,6 @@ export interface SignInWithEmailLinkRequest { tenantId?: string; } -// add a comment to trigger packages/auth CI tests export interface SignInWithEmailLinkResponse extends IdTokenResponse { email: string; isNewUser: boolean;