Skip to content

Revert "Install latest chrome version for "Test Auth on Chrome and Node If Changed" test" #7207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 7, 2023
Merged

Revert "Install latest chrome version for "Test Auth on Chrome and Node If Changed" test" #7207

merged 4 commits into from
Apr 7, 2023

Conversation

@NhienLam
Copy link
Contributor

@NhienLam NhienLam commented Apr 6, 2023 •
edited by prameshj
Loading

This reverts #7197 which unpinned the chrome version in "Test Auth on Chrome and Node If Changed".

The test still fails on version 111. Tests passed in the above PR because there were no code changes to auth.

Chrome version 112 has not become stable yet, so sudo apt-get install google-chrome-stable still installs version 111.

@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 33ed31a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 6, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (f1b1c5a) and merge commit (6df5ab2).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/S0fVBqW7wC.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 6, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (f1b1c5a) and merge commit (6df5ab2).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4RXThWAKnM.html

@NhienLam NhienLam changed the title [Do not merge] Pin Chrome version that passes "Test Auth on Chrome and Node If Changed" test Pin Chrome version for "Test Auth on Chrome and Node If Changed" test Apr 6, 2023
@NhienLam NhienLam changed the title Pin Chrome version for "Test Auth on Chrome and Node If Changed" test Revert "Install latest chrome version for "Test Auth on Chrome and Node If Changed" test" Apr 6, 2023
@NhienLam NhienLam merged commit fb6df83 into master Apr 7, 2023
@NhienLam NhienLam deleted the webdriver-chromeversion branch April 7, 2023 22:32
@firebase firebase locked and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@prameshj prameshj prameshj approved these changes

@lisajian lisajian Awaiting requested review from lisajian

@sam-gc sam-gc Awaiting requested review from sam-gc

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

+1 more reviewer

@renkelvin renkelvin renkelvin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NhienLam @google-oss-bot @renkelvin @hsubox76 @prameshj