From b367cb9c334172a06e27fdd185981d3a32b23861 Mon Sep 17 00:00:00 2001 From: Denver Coneybeare Date: Wed, 8 Feb 2023 23:53:23 -0500 Subject: [PATCH] spec_test_runner.ts: sort document changes before comparing for pairwise correctness --- packages/firestore/test/unit/specs/spec_test_runner.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/firestore/test/unit/specs/spec_test_runner.ts b/packages/firestore/test/unit/specs/spec_test_runner.ts index e64dcbfd214..33bdcc49514 100644 --- a/packages/firestore/test/unit/specs/spec_test_runner.ts +++ b/packages/firestore/test/unit/specs/spec_test_runner.ts @@ -1172,7 +1172,13 @@ abstract class TestRunner { }); } - expect(actual.view!.docChanges).to.deep.equal(expectedChanges); + const actualChangesSorted = Array.from(actual.view!.docChanges).sort( + (a, b) => primitiveComparator(a.doc, b.doc) + ); + const expectedChangesSorted = Array.from(expectedChanges).sort((a, b) => + primitiveComparator(a.doc, b.doc) + ); + expect(actualChangesSorted).to.deep.equal(expectedChangesSorted); expect(actual.view!.hasPendingWrites).to.equal( expected.hasPendingWrites,