Skip to content

Conversation

@hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Feb 2, 2022

Replace sending v1 platform logging header with sending new heartbeats header.

Additionally:

  • Sending the header to the "createInstallation" endpoint, which happens when an installations ID is registered. Previously it was only being sent to the "authTokens:generate" endpoint, which only happens on the auth token refresh, starting 7 days after registration.
  • Adding app ID param to the body sent to the authTokens:generate endpoint.

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2022

🦋 Changeset detected

Latest commit: 8bd4255

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@firebase/installations Patch
@firebase/analytics Patch
firebase Patch
@firebase/installations-compat Patch
@firebase/messaging Patch
@firebase/performance Patch
@firebase/remote-config Patch
@firebase/analytics-compat Patch
@firebase/messaging-compat Patch
@firebase/performance-compat Patch
@firebase/remote-config-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 2, 2022

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (b3e4af8)Merge (6c772ed)Diff
    browser251 kB248 kB-2.24 kB (-0.9%)
    esm5311 kB309 kB-2.16 kB (-0.7%)
    main500 kB498 kB-2.56 kB (-0.5%)
    module251 kB248 kB-2.24 kB (-0.9%)
    react-native251 kB249 kB-2.24 kB (-0.9%)
  • @firebase/installations

    TypeBase (b3e4af8)Merge (6c772ed)Diff
    browser17.3 kB17.8 kB+512 B (+3.0%)
    esm522.3 kB23.0 kB+658 B (+2.9%)
    main23.1 kB23.8 kB+658 B (+2.8%)
    module17.3 kB17.8 kB+512 B (+3.0%)
  • bundle

    11 size changes

    TypeBase (b3e4af8)Merge (6c772ed)Diff
    analytics (logEvent)41.8 kB42.0 kB+235 B (+0.6%)
    firestore (Persistence)263 kB261 kB-2.24 kB (-0.9%)
    firestore (Query Cursors)203 kB203 kB+224 B (+0.1%)
    firestore (Query)204 kB204 kB+224 B (+0.1%)
    firestore (Read data once)193 kB193 kB+224 B (+0.1%)
    firestore (Realtime updates)195 kB195 kB+224 B (+0.1%)
    firestore (Transaction)177 kB178 kB+224 B (+0.1%)
    firestore (Write data)177 kB177 kB+224 B (+0.1%)
    messaging (send + receive)44.9 kB45.1 kB+235 B (+0.5%)
    performance (trace)49.4 kB49.7 kB+235 B (+0.5%)
    remote-config (getAndFetch)44.1 kB44.4 kB+235 B (+0.5%)

  • firebase

    14 size changes

    TypeBase (b3e4af8)Merge (6c772ed)Diff
    firebase-analytics-compat.js26.0 kB26.2 kB+202 B (+0.8%)
    firebase-analytics.js107 kB108 kB+693 B (+0.6%)
    firebase-compat.js779 kB777 kB-2.07 kB (-0.3%)
    firebase-firestore-compat.js302 kB300 kB-2.27 kB (-0.8%)
    firebase-firestore.js835 kB818 kB-17.9 kB (-2.1%)
    firebase-messaging-compat.js38.0 kB38.2 kB+202 B (+0.5%)
    firebase-messaging-sw.js102 kB103 kB+693 B (+0.7%)
    firebase-messaging.js101 kB102 kB+693 B (+0.7%)
    firebase-performance-compat.js30.8 kB31.0 kB+202 B (+0.7%)
    firebase-performance-standalone-compat.es2017.js87.5 kB87.7 kB+228 B (+0.3%)
    firebase-performance-standalone-compat.js65.7 kB66.0 kB+294 B (+0.4%)
    firebase-performance.js119 kB119 kB+693 B (+0.6%)
    firebase-remote-config-compat.js27.5 kB27.7 kB+202 B (+0.7%)
    firebase-remote-config.js109 kB109 kB+693 B (+0.6%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AlZaRZEs2a.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 2, 2022

Size Analysis Report 1

This report is too large (526,763 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0T96X8ZgRG.html

@google-oss-bot google-oss-bot added the doc-changes PRs that affect docs label Feb 2, 2022
@hsubox76 hsubox76 assigned avolkovi and yoyomyo and unassigned egilmorez Feb 2, 2022
@hsubox76 hsubox76 requested a review from sam-gc February 8, 2022 01:33
@hsubox76 hsubox76 assigned sam-gc and unassigned avolkovi Feb 8, 2022
Base automatically changed from ch-heartbeat to master February 24, 2022 18:34
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there's only one public comment string here, and it looks fine. Thanks!

Copy link

@yoyomyo yoyomyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes!

@hsubox76 hsubox76 merged commit ddeff83 into master Mar 15, 2022
@hsubox76 hsubox76 deleted the ch-hb-fis branch March 15, 2022 18:39
@google-oss-bot google-oss-bot mentioned this pull request Mar 16, 2022
@firebase firebase locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

doc-changes PRs that affect docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants