From 04abecfe3844b58e8b17a3c425b9bcc50ef70877 Mon Sep 17 00:00:00 2001 From: Dennis Simon Date: Mon, 12 Jul 2021 18:37:36 +0200 Subject: [PATCH 1/4] Add @firebase/logger as devDependency to app-types --- packages/app-types/package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/app-types/package.json b/packages/app-types/package.json index 1399c717b5f..8a4b5b77d54 100644 --- a/packages/app-types/package.json +++ b/packages/app-types/package.json @@ -21,6 +21,7 @@ "url": "https://github.com/firebase/firebase-js-sdk/issues" }, "devDependencies": { - "typescript": "4.2.2" + "typescript": "4.2.2", + "@firebase/logger": "0.x" } } From 41d8b2d85de01cef5ef64a87cb471f809d5c6f96 Mon Sep 17 00:00:00 2001 From: Dennis Simon Date: Tue, 13 Jul 2021 02:16:17 +0200 Subject: [PATCH 2/4] Change @firebase/logger dependency type to peerDependency --- packages/app-types/package.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/app-types/package.json b/packages/app-types/package.json index 8a4b5b77d54..cd33e4548dd 100644 --- a/packages/app-types/package.json +++ b/packages/app-types/package.json @@ -21,7 +21,9 @@ "url": "https://github.com/firebase/firebase-js-sdk/issues" }, "devDependencies": { - "typescript": "4.2.2", + "typescript": "4.2.2" + }, + "peerDependency": { "@firebase/logger": "0.x" } } From d51960accf5f41fea720cfe4680259a71b9a0f4d Mon Sep 17 00:00:00 2001 From: Dennis Simon Date: Wed, 14 Jul 2021 00:55:43 +0200 Subject: [PATCH 3/4] Pin @firebase/logger version and add as a dependency --- packages/app-types/package.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/app-types/package.json b/packages/app-types/package.json index cd33e4548dd..b320511347c 100644 --- a/packages/app-types/package.json +++ b/packages/app-types/package.json @@ -20,10 +20,10 @@ "bugs": { "url": "https://github.com/firebase/firebase-js-sdk/issues" }, + "dependency": { + "@firebase/logger": "0.2.6" + }, "devDependencies": { "typescript": "4.2.2" - }, - "peerDependency": { - "@firebase/logger": "0.x" } } From e7f7cc9e8c0523397e5483e9e154704734c3d7f5 Mon Sep 17 00:00:00 2001 From: Dennis Simon Date: Thu, 15 Jul 2021 00:32:14 +0200 Subject: [PATCH 4/4] Add changeset --- .changeset/short-lies-sing.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/short-lies-sing.md diff --git a/.changeset/short-lies-sing.md b/.changeset/short-lies-sing.md new file mode 100644 index 00000000000..2b630ddcc3e --- /dev/null +++ b/.changeset/short-lies-sing.md @@ -0,0 +1,5 @@ +--- +'@firebase/app-types': patch +--- + +Add @firebase/logger as a dependency to @firebase/app-types to ensure that it can be resolved when compiling the package in a strict yarn PnP environment.