Skip to content

create rollup typings for messaging #4974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2021
Merged

create rollup typings for messaging #4974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
701e896
create rollup typings for messaging
Feiyang1 Jun 3, 2021
e2550f1
update
Feiyang1 Jun 4, 2021
2fd5781
update string
Feiyang1 Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages-exp/messaging-compat/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"test:karma": "karma start --single-run",
"test:debug": "karma start --browsers=Chrome --auto-watch",
"type-check": "tsc --noEmit",
"add-compat-overloads": "ts-node-script ../../scripts/exp/create-overloads.ts -i ../messaging-exp/dist/messaging-exp-public.d.ts -o dist/src/index.d.ts -a -r FirebaseMessaging:MessagingCompat -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/messaging"
"add-compat-overloads": "ts-node-script ../../scripts/exp/create-overloads.ts -i ../messaging-exp/dist/index-public.d.ts -o dist/src/index.d.ts -a -r FirebaseMessaging:MessagingCompat -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/messaging"
},
"peerDependencies": {
"@firebase/app-compat": "0.x"
Expand Down
11 changes: 9 additions & 2 deletions packages-exp/messaging-exp/api-extractor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,15 @@
}],
"dtsRollup": {
/**
* rollup is not supported when multiple entry points are present
* rollup is not supported when multiple entry points are present.
* npm script api-report:rollup is used to generate dts rollup.
*/
"enabled": false
}
},
"apiReport": {
/**
* apiReport is handled by npm script api-report:rollup
*/
"enabled": false
}
}
11 changes: 7 additions & 4 deletions packages-exp/messaging-exp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,18 @@
"lint:fix": "eslint --fix -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
"build": "rollup -c && yarn api-report",
"build:deps": "lerna run --scope @firebase/'{app-exp,messaging-exp}' --include-dependencies build",
"build:release": "rollup -c rollup.config.release.js && yarn api-report",
"build:release": "rollup -c rollup.config.release.js && yarn api-report && yarn typings:public",
"dev": "rollup -c -w",
"test": "run-p test:karma type-check lint ",
"test:integration": "run-p test:karma type-check lint && cd ../../integration/messaging && npm run-script test",
"test:ci": "node ../../scripts/run_tests_in_ci.js",
"test:karma": "karma start --single-run",
"test:debug": "karma start --browsers=Chrome --auto-watch",
"api-report": "api-extractor run --local --verbose",
"type-check": "tsc --noEmit"
"api-report": "yarn api-report:rollup && yarn api-report:api-json",
"api-report:rollup": "ts-node-script ../../repo-scripts/prune-dts/extract-public-api.ts --package messaging-exp --packageRoot . --typescriptDts ./dist/index.d.ts --rollupDts ./dist/private.d.ts --untrimmedRollupDts ./dist/internal.d.ts --publicDts ./dist/index-public.d.ts",
"api-report:api-json": "api-extractor run --local --verbose",
"type-check": "tsc --noEmit",
"typings:public": "node ../../scripts/exp/use_typings.js ./dist/index-public.d.ts"
},
"license": "Apache-2.0",
"peerDependencies": {
Expand Down Expand Up @@ -54,4 +57,4 @@
"url": "https://github.com/firebase/firebase-js-sdk/issues"
},
"esm5": "dist/index.esm.js"
}
}