Add generics to httpsCallable #4466
Conversation
|
Size Analysis Report |
hsubox76
force-pushed
the
ch-httpscallable-type
branch
from
fad56ab to
d7692c2
Compare
| it('scalars', async () => { | ||
| const functions = createTestService(app, region); | ||
| const func = httpsCallable(functions, 'scalarTest'); | ||
| const func = httpsCallable<number, number>(functions, 'scalarTest'); |
There was a problem hiding this comment.
I believe at least the request (and maybe the response as well) must be objects. Scalars may not be allowed by the server-side implementation.
There was a problem hiding this comment.
This is a live test that sends a number to the server and successfully gets a number response so it seems to work, unless I'm misunderstanding. To make sure, I also created a new onCall function that logged a number sent to it and returned a number and tried it from a test app and it seems to work:
exports.numberTest = functions.https.onCall((data) => {
console.log(data, typeof data);
return(44);
});
Let me know if I misunderstood.
hsubox76
force-pushed
the
ch-httpscallable-type
branch
from
14dbd51 to
4b7a353
Compare
hsubox76
force-pushed
the
ch-httpscallable-type
branch
from
4b7a353 to
b4c1b5d
Compare
4 participants
Add
RequestDataandResponseDatagenerics tohttpsCallable.RequestDatais the arg provided to the callable function (only one allowed). The callable function returns a promise with adatafield, andRequestDatadescribes whatever is in that data field.Used the generics in a couple of
httpsCallabletests as a check to make sure the typing works, and left them out of some tests to make sure it also works if they are omitted.