Merge master into release

Author: google-oss-bot

.changeset/good-bears-obey.md

@@ -0,0 +1,5 @@
+---
+"@firebase/database": patch
+---
+
+Included experimental support for Deno

.changeset/happy-eels-confess.md

@@ -0,0 +1,5 @@
+---
+"@firebase/auth": patch
+---
+
+Fix proactive refresh logic in Auth when RTDB/Firestore/Storage are in use

.changeset/smart-plants-sparkle.md

@@ -0,0 +1,5 @@
+---
+'@firebase/firestore': patch
+---
+
+Fix FAILED_PRECONDITION when writing to a deleted document in a transaction (#5871)

.github/workflows/deploy-config.yml

@@ -0,0 +1,32 @@
+name: Deploy Project Config
+
+on: pull_request
+
+# Detects if any project config files (rules or functions) have changed,
+# and deploys them to the test project used for CI if so.
+# Run this in its own workflow instead of as a step before each test
+# workflow to avoid too many deploys, possibly causing race conditions.
+# Since the build step of each test workflow takes a long time, this
+# this should finish before the tests begin running.
+
+jobs:
+  test:
+    name: Deploy Firebase Project Rules and Functions
+    runs-on: ubuntu-latest
+
+    steps:
+    - name: Checkout Repo
+      uses: actions/checkout@master
+      with:
+        # This makes Actions fetch all Git history so run-changed script can diff properly.
+        fetch-depth: 0
+    - name: Set up Node (14)
+      uses: actions/setup-node@v2
+      with:
+        node-version: 14.x
+    - name: Yarn install
+      run: yarn
+    - name: Deploy project config if needed
+      run: yarn ts-node scripts/ci-test/deploy-if-needed.ts
+      env:
+        FIREBASE_CLI_TOKEN: ${{secrets.FIREBASE_CLI_TOKEN}}

.github/workflows/test-changed-auth.yml

@@ -63,10 +63,6 @@ jobs:
       - name: build
         run: yarn build:changed auth
       - name: Run tests on auth changed packages
-        run: xvfb-run yarn --cwd packages/auth test:browser:unit
-        env:
-          BROWSERS: 'Firefox'
-      - name: Run tests on auth-compat changed packages
-        run: xvfb-run yarn --cwd packages/auth-compat test:browser:unit
+        run: xvfb-run yarn test:changed auth
         env:
           BROWSERS: 'Firefox'

.github/workflows/test-changed-firestore.yml

@@ -3,31 +3,62 @@ name: Test Firestore
 on: pull_request
 
 jobs:
-  test:
-    name: Test Firestore If Changed
+  test-chrome:
+    name: Test Firestore on Chrome and Node If Changed
     runs-on: ubuntu-latest
 
     steps:
-    - name: Checkout Repo
-      uses: actions/checkout@master
-      with:
-        # This makes Actions fetch all Git history so run-changed script can diff properly.
-        fetch-depth: 0
-    - name: Set up Node (14)
-      uses: actions/setup-node@v2
-      with:
-        node-version: 14.x
-    - name: install Chrome stable
-      run: |
-        sudo apt-get update
-        sudo apt-get install google-chrome-stable
-    - name: Bump Node memory limit
-      run: echo "NODE_OPTIONS=--max_old_space_size=4096" >> $GITHUB_ENV
-    - name: Test setup and yarn install
-      run: |
-        cp config/ci.config.json config/project.json
-        yarn
-    - name: build
-      run: yarn build:changed firestore
-    - name: Run tests if firestore or its dependencies has changed
-      run: yarn test:changed firestore
+      - name: Checkout Repo
+        uses: actions/checkout@master
+        with:
+          # This makes Actions fetch all Git history so run-changed script can diff properly.
+          fetch-depth: 0
+      - name: Set up Node (14)
+        uses: actions/setup-node@v2
+        with:
+          node-version: 14.x
+      - name: install Chrome stable
+        run: |
+          sudo apt-get update
+          sudo apt-get install google-chrome-stable
+      - name: Bump Node memory limit
+        run: echo "NODE_OPTIONS=--max_old_space_size=4096" >> $GITHUB_ENV
+      - name: Test setup and yarn install
+        run: |
+          cp config/ci.config.json config/project.json
+          yarn
+      - name: build
+        run: yarn build:changed firestore
+      - name: Run tests if firestore or its dependencies has changed
+        run: yarn test:changed firestore
+
+  test-firefox:
+    name: Test Firestore on Firefox If Changed
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: install Firefox stable
+        run: |
+          sudo apt-get update
+          sudo apt-get install firefox
+      - name: Checkout Repo
+        uses: actions/checkout@master
+        with:
+          # This makes Actions fetch all Git history so run-changed script can diff properly.
+          fetch-depth: 0
+      - name: Set up Node (14)
+        uses: actions/setup-node@v2
+        with:
+          node-version: 14.x
+      - name: Bump Node memory limit
+        run: echo "NODE_OPTIONS=--max_old_space_size=4096" >> $GITHUB_ENV
+      - name: Test setup and yarn install
+        run: |
+          cp config/ci.config.json config/project.json
+          yarn
+      - name: build
+        run: yarn build:changed firestore
+      - name: Run tests if firestore or its dependencies has changed
+        run: xvfb-run yarn test:changed firestore
+        env:
+          BROWSERS: 'Firefox'

common/api-review/firestore-lite.api.md

@@ -176,7 +176,10 @@ export function getDoc<T>(reference: DocumentReference<T>): Promise<DocumentSnap
 export function getDocs<T>(query: Query<T>): Promise<QuerySnapshot<T>>;
 
 // @public
-export function getFirestore(app?: FirebaseApp): Firestore;
+export function getFirestore(): Firestore;
+
+// @public
+export function getFirestore(app: FirebaseApp): Firestore;
 
 // @public
 export function increment(n: number): FieldValue;

common/api-review/firestore.api.md

@@ -228,13 +228,16 @@ export function getDocsFromCache<T>(query: Query<T>): Promise<QuerySnapshot<T>>;
 export function getDocsFromServer<T>(query: Query<T>): Promise<QuerySnapshot<T>>;
 
 // @public
-export function getFirestore(app?: FirebaseApp): Firestore;
+export function getFirestore(): Firestore;
+
+// @public
+export function getFirestore(app: FirebaseApp): Firestore;
 
 // @public
 export function increment(n: number): FieldValue;
 
 // @public
-export function initializeFirestore(app: FirebaseApp, settings: FirestoreSettings): Firestore;
+export function initializeFirestore(app: FirebaseApp, settings: FirestoreSettings, databaseId?: string): Firestore;
 
 // @public
 export function limit(limit: number): QueryConstraint;

integration/firestore/firebase_export.ts

@@ -27,19 +27,25 @@ import {
 
 let appCount = 0;
 
+export function newTestApp(projectId: string, appName?: string): FirebaseApp {
+  if (appName === undefined) {
+    appName = 'test-app-' + appCount++;
+  }
+  return initializeApp(
+    {
+      apiKey: 'fake-api-key',
+      projectId
+    },
+    appName
+  );
+}
+
 export function newTestFirestore(
-  projectId: string,
-  nameOrApp?: string | FirebaseApp,
-  settings?: FirestoreSettings
+  app: FirebaseApp,
+  settings?: FirestoreSettings,
+  dbName?: string
 ): Firestore {
-  if (nameOrApp === undefined) {
-    nameOrApp = 'test-app-' + appCount++;
-  }
-  const app =
-    typeof nameOrApp === 'string'
-      ? initializeApp({ apiKey: 'fake-api-key', projectId }, nameOrApp)
-      : nameOrApp;
-  return initializeFirestore(app, settings || {});
+  return initializeFirestore(app, settings || {}, dbName);
 }
 
 export * from '@firebase/firestore';

packages/auth/src/core/auth/auth_impl.test.ts

@@ -306,6 +306,65 @@ describe('core/auth/auth_impl', () => {
         });
       });
 
+      context('with Proactive Refresh', () => {
+        let oldUser: UserInternal;
+
+        beforeEach(() => {
+          oldUser = testUser(auth, 'old-user-uid');
+
+          for (const u of [user, oldUser]) {
+            sinon.spy(u, '_startProactiveRefresh');
+            sinon.spy(u, '_stopProactiveRefresh');
+          }
+        });
+
+        it('null -> user: does not turn on if not enabled', async () => {
+          await auth._updateCurrentUser(null);
+          await auth._updateCurrentUser(user);
+
+          expect(user._startProactiveRefresh).not.to.have.been.called;
+        });
+
+        it('null -> user: turns on if enabled', async () => {
+          await auth._updateCurrentUser(null);
+          auth._startProactiveRefresh();
+          await auth._updateCurrentUser(user);
+
+          expect(user._startProactiveRefresh).to.have.been.called;
+        });
+
+        it('user -> user: does not turn on if not enabled', async () => {
+          await auth._updateCurrentUser(oldUser);
+          await auth._updateCurrentUser(user);
+
+          expect(user._startProactiveRefresh).not.to.have.been.called;
+        });
+
+        it('user -> user: turns on if enabled', async () => {
+          auth._startProactiveRefresh();
+          await auth._updateCurrentUser(oldUser);
+          await auth._updateCurrentUser(user);
+
+          expect(oldUser._stopProactiveRefresh).to.have.been.called;
+          expect(user._startProactiveRefresh).to.have.been.called;
+        });
+
+        it('calling start on auth triggers user to start', async () => {
+          await auth._updateCurrentUser(user);
+          auth._startProactiveRefresh();
+
+          expect(user._startProactiveRefresh).to.have.been.calledOnce;
+        });
+
+        it('calling stop stops the refresh on the current user', async () => {
+          auth._startProactiveRefresh();
+          await auth._updateCurrentUser(user);
+          auth._stopProactiveRefresh();
+
+          expect(user._stopProactiveRefresh).to.have.been.called;
+        });
+      });
+
       it('onAuthStateChange works for multiple listeners', async () => {
         const cb1 = sinon.spy();
         const cb2 = sinon.spy();