Skip to content

Commit cafed75

Browse files
committed
Omit name from FirebaseServerAppSettings.
1 parent 292dcb7 commit cafed75

File tree

4 files changed

+2
-15
lines changed

4 files changed

+2
-15
lines changed

common/api-review/app.api.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,8 @@ export interface FirebaseServerApp extends FirebaseApp {
7878
}
7979

8080
// @public
81-
export interface FirebaseServerAppSettings extends FirebaseAppSettings {
81+
export interface FirebaseServerAppSettings extends Omit<FirebaseAppSettings, "name?"> {
8282
authIdToken?: string;
83-
name?: string;
8483
releaseOnDeref?: object;
8584
}
8685

packages/app/src/api.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,8 +252,6 @@ export function initializeServerApp(
252252
...appOptions
253253
};
254254

255-
delete nameObj.name;
256-
257255
// However, Do not mangle the name based on releaseOnDeref, since it will vary between the
258256
// construction of FirebaseServerApp instances. For example, if the object is the request headers.
259257
if (nameObj.releaseOnDeref !== undefined) {

packages/app/src/firebaseServerApp.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,6 @@ export class FirebaseServerAppImpl
6767
...serverConfig
6868
};
6969

70-
delete this._serverConfig.name;
71-
7270
this._finalizationRegistry = new FinalizationRegistry(() => {
7371
this.automaticCleanup();
7472
});

packages/app/src/public-types.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ export interface FirebaseAppSettings {
175175
*
176176
* Configuration options given to {@link (initializeServerApp:1) | initializeServerApp()}
177177
*/
178-
export interface FirebaseServerAppSettings extends FirebaseAppSettings {
178+
export interface FirebaseServerAppSettings extends Omit<FirebaseAppSettings, "name?"> {
179179
/**
180180
* An optional Auth ID token used to resume a signed in user session from a client
181181
* runtime environment.
@@ -215,14 +215,6 @@ export interface FirebaseServerAppSettings extends FirebaseAppSettings {
215215
* initialization.
216216
*/
217217
releaseOnDeref?: object;
218-
219-
/**
220-
* There is no `getApp()` operation for `FirebaseServerApp`, so the name is not relevant for
221-
* applications. Therefore, this field will be ignored during `FirebaseServerApp` initialization,
222-
* and is defined here solely to conform to TypeScript's `exactOptionalPropertyTypes`
223-
* requirements.
224-
*/
225-
name?: string;
226218
}
227219

228220
/**

0 commit comments

Comments
 (0)