break build steps down

Author: wu-hui

.github/workflows/test-changed-firestore.yml

@@ -35,23 +35,24 @@ jobs:
           yarn
       - name: build
         id: build
-        # TODO(wuandy): Separate yarn and egrep into steps, so build failure
-        # is captured by github actions.
-        run: yarn build:changed firestore | egrep "Skipping all"
+        run: yarn build:changed firestore | tee ${{ runner.temp }}/yarn.log.txt
+      - name: Check if Firestore is changed
+        id: check-changed
+        run: egrep "Skipping all" ${{ runner.temp }}/yarn.log.txt
         # Continue when "Skipping all" is not found
         continue-on-error: true
       - name: set output
         # This means "Skipping all" was not found
-        if: steps.build.outcome != 'success'
+        if: steps.check-changed.outcome != 'success'
         id: set-output
         run: echo "CHANGED=true" >> "$GITHUB_OUTPUT";
       - name: Archive build
-        if: ${{ !cancelled() && steps.build.outcome != 'success' }}
+        if: ${{ !cancelled() && steps.check-changed.outcome != 'success' }}
         run: |
           tar -cf build.tar --exclude=.git .
           gzip build.tar
       - name: Upload build archive
-        if: ${{ !cancelled() && steps.build.outcome != 'success' }}
+        if: ${{ !cancelled() && steps.check-changed.outcome != 'success' }}
         uses: actions/upload-artifact@v3
         with:
           name: build.tar.gz

packages/firestore/src/api/database.ts

@@ -121,7 +121,7 @@ export class Firestore extends LiteFirestore {
       // usage throws an exception.
       configureFirestore(this);
     }
-    return null;
+    return this._firestoreClient!.terminate();
   }
 }