Fix types

Author: hsubox76

common/api-review/functions-exp.api.md

@@ -14,7 +14,7 @@ export interface Functions {
     region: string;
 }
 
-// @public (undocumented)
+// @public
 export interface FunctionsError extends FirebaseError {
     readonly code: FunctionsErrorCode;
     readonly details?: unknown;
@@ -27,9 +27,9 @@ export type FunctionsErrorCode = 'ok' | 'cancelled' | 'unknown' | 'invalid-argum
 export function getFunctions(app: FirebaseApp, regionOrCustomDomain?: string): Functions;
 
 // @public
-export interface HttpsCallable {
+export interface HttpsCallable<RequestData = unknown, ResponseData = unknown> {
     // (undocumented)
-    (data?: {} | null): Promise<HttpsCallableResult>;
+    (data?: RequestData | null): Promise<HttpsCallableResult<ResponseData>>;
 }
 
 // @public
@@ -42,9 +42,9 @@ export interface HttpsCallableOptions {
 }
 
 // @public
-export interface HttpsCallableResult {
+export interface HttpsCallableResult<ResponseData = unknown> {
     // (undocumented)
-    readonly data: unknown;
+    readonly data: ResponseData;
 }
 
 // @public

packages-exp/functions-exp/src/public-types.ts

@@ -19,6 +19,7 @@ import { FirebaseError } from '@firebase/util';
 
 /**
  * An HttpsCallableResult wraps a single result from a function call.
+ * @public
  */
 export interface HttpsCallableResult<ResponseData = unknown> {
   readonly data: ResponseData;
@@ -27,13 +28,15 @@ export interface HttpsCallableResult<ResponseData = unknown> {
 /**
  * An HttpsCallable is a reference to a "callable" http trigger in
  * Google Cloud Functions.
+ * @public
  */
 export interface HttpsCallable<RequestData = unknown, ResponseData = unknown> {
   (data?: RequestData | null): Promise<HttpsCallableResult<ResponseData>>;
 }
 
 /**
  * HttpsCallableOptions specify metadata about how calls should be executed.
+ * @public
  */
 export interface HttpsCallableOptions {
   timeout?: number; // in millis
@@ -42,6 +45,7 @@ export interface HttpsCallableOptions {
 /**
  * `Functions` represents a Functions instance, and is a required argument for
  * all Functions operations.
+ * @public
  */
 export interface Functions {
   /**
@@ -100,6 +104,7 @@ export interface Functions {
  * - 'data-loss': Unrecoverable data loss or corruption.
  * - 'unauthenticated': The request does not have valid authentication
  *   credentials for the operation.
+ * @public
  */
 export type FunctionsErrorCode =
   | 'ok'
@@ -120,6 +125,10 @@ export type FunctionsErrorCode =
   | 'data-loss'
   | 'unauthenticated';
 
+/**
+ * An error returned by the Firebase Functions client SDK.
+ * @public
+ */
 export interface FunctionsError extends FirebaseError {
   /**
    * A standard error code that will be returned to the client. This also