PR feedback

Author: sam-gc

packages/auth/src/platform_browser/auth.test.ts

@@ -472,9 +472,8 @@ describe('core/auth/initializeAuth', () => {
           _getInstance<PersistenceInternal>(inMemoryPersistence)
         );
         stub._get.returns(Promise.resolve(null));
-        let user: UserInternal | null = null;
         completeRedirectFnStub.callsFake((auth: AuthInternal) => {
-          user = testUser(auth, 'uid', '[email protected]');
+          const user = testUser(auth, 'uid', '[email protected]');
           return Promise.resolve(
             new UserCredentialImpl({
               operationType: OperationType.SIGN_IN,
@@ -490,7 +489,7 @@ describe('core/auth/initializeAuth', () => {
           FAKE_APP.options.authDomain,
           /* blockMiddleware */ true
         );
-        expect(user).not.to.be.null;
+        expect(completeRedirectFnStub).to.have.been.called;
         expect(auth.currentUser).to.be.null;
         expect(reload._reloadWithoutSaving).not.to.have.been.called;
       });

packages/auth/test/integration/webdriver/persistence.test.ts

@@ -284,13 +284,13 @@ browserDescribe('WebDriver persistence test', (driver, browser) => {
         .that.contains({ uid: user.uid });
     });
 
-    it('migrates user when switching from indexedDB to localStorage', async () => {
+    it('migrates user when switching from indexedDB to localStorage', async function() {
       // This test only works in the modular SDK: the compat package does not
       // make the distinction between indexedDB and local storage (both are just
       // 'local').
       if (driver.isCompatLayer()) {
         console.warn('Skipping indexedDB to local migration in compat test');
-        return;
+        this.skip();
       }
 
       await driver.call(AnonFunction.SIGN_IN_ANONYMOUSLY);
@@ -462,11 +462,11 @@ browserDescribe('WebDriver persistence test', (driver, browser) => {
       expect(await driver.getUserSnapshot()).to.contain({ uid: uid2 });
     });
 
-    it('middleware does not block tab sync', async () => {
+    it('middleware does not block tab sync', async function() {
       if (driver.isCompatLayer()) {
         // Compat layer is skipped because it doesn't support middleware
         console.warn('Skipping middleware tabs in compat test');
-        return;
+        this.skip();
       }
 
       // Blocking middleware in main page

packages/auth/test/integration/webdriver/popup.test.ts

@@ -64,10 +64,10 @@ browserDescribe('Popup IdP tests', driver => {
     expect(result.user).to.eql(currentUser);
   });
 
-  it('is blocked by auth middleware', async () => {
+  it('is blocked by auth middleware', async function () {
     if (driver.isCompatLayer()) {
       // Compat layer doesn't support middleware yet
-      return;
+      this.skip();
     }
 
     await driver.call(MiddlewareFunction.ATTACH_BLOCKING_MIDDLEWARE);

packages/auth/test/integration/webdriver/redirect.test.ts

@@ -74,10 +74,10 @@ browserDescribe('WebDriver redirect IdP test', driver => {
   });
 
   // Redirect works with middleware for now
-  it('is blocked by middleware', async () => {
+  it('is blocked by middleware', async function () {
     if (driver.isCompatLayer()) {
       console.warn('Skipping middleware tests in compat');
-      return;
+      this.skip();
     }
 
     await driver.callNoWait(RedirectFunction.IDP_REDIRECT);