WIP: review comments #2

Author: jshcrowthe

src/database/api/TransactionResult.ts

@@ -6,14 +6,5 @@ export class TransactionResult {
    * @param {boolean} committed
    * @param {fb.api.DataSnapshot} snapshot
    */
-  constructor(committed, snapshot) {
-    /**
-    * @type {boolean}
-    */
-    this['committed'] = committed;
-    /**
-    * @type {fb.api.DataSnapshot}
-    */
-    this['snapshot'] = snapshot;
-  }
+  constructor(public committed, public snapshot) {}
 }

src/database/api/onDisconnect.ts

@@ -29,24 +29,24 @@ export class OnDisconnect {
    * @param {function(?Error)=} opt_onComplete
    * @return {!firebase.Promise}
    */
-  cancel(opt_onComplete) {
+  cancel(onComplete?) {
     validateArgCount('OnDisconnect.cancel', 0, 1, arguments.length);
-    validateCallback('OnDisconnect.cancel', 1, opt_onComplete, true);
+    validateCallback('OnDisconnect.cancel', 1, onComplete, true);
     const deferred = new Deferred();
-    this.repo_.onDisconnectCancel(this.path_, deferred.wrapCallback(opt_onComplete));
+    this.repo_.onDisconnectCancel(this.path_, deferred.wrapCallback(onComplete));
     return deferred.promise;
   }
 
   /**
    * @param {function(?Error)=} opt_onComplete
    * @return {!firebase.Promise}
    */
-  remove(opt_onComplete) {
+  remove(onComplete?) {
     validateArgCount('OnDisconnect.remove', 0, 1, arguments.length);
     validateWritablePath('OnDisconnect.remove', this.path_);
-    validateCallback('OnDisconnect.remove', 1, opt_onComplete, true);
+    validateCallback('OnDisconnect.remove', 1, onComplete, true);
     const deferred = new Deferred();
-    this.repo_.onDisconnectSet(this.path_, null, deferred.wrapCallback(opt_onComplete));
+    this.repo_.onDisconnectSet(this.path_, null, deferred.wrapCallback(onComplete));
     return deferred.promise;
   }
 
@@ -55,13 +55,13 @@ export class OnDisconnect {
    * @param {function(?Error)=} opt_onComplete
    * @return {!firebase.Promise}
    */
-  set(value, opt_onComplete) {
+  set(value, onComplete?) {
     validateArgCount('OnDisconnect.set', 1, 2, arguments.length);
     validateWritablePath('OnDisconnect.set', this.path_);
     validateFirebaseDataArg('OnDisconnect.set', 1, value, this.path_, false);
-    validateCallback('OnDisconnect.set', 2, opt_onComplete, true);
+    validateCallback('OnDisconnect.set', 2, onComplete, true);
     const deferred = new Deferred();
-    this.repo_.onDisconnectSet(this.path_, value, deferred.wrapCallback(opt_onComplete));
+    this.repo_.onDisconnectSet(this.path_, value, deferred.wrapCallback(onComplete));
     return deferred.promise;
   }
 
@@ -71,16 +71,16 @@ export class OnDisconnect {
    * @param {function(?Error)=} opt_onComplete
    * @return {!firebase.Promise}
    */
-  setWithPriority(value, priority, opt_onComplete) {
+  setWithPriority(value, priority, onComplete?) {
     validateArgCount('OnDisconnect.setWithPriority', 2, 3, arguments.length);
     validateWritablePath('OnDisconnect.setWithPriority', this.path_);
     validateFirebaseDataArg('OnDisconnect.setWithPriority',
       1, value, this.path_, false);
     validatePriority('OnDisconnect.setWithPriority', 2, priority, false);
-    validateCallback('OnDisconnect.setWithPriority', 3, opt_onComplete, true);
+    validateCallback('OnDisconnect.setWithPriority', 3, onComplete, true);
 
     const deferred = new Deferred();
-    this.repo_.onDisconnectSetWithPriority(this.path_, value, priority, deferred.wrapCallback(opt_onComplete));
+    this.repo_.onDisconnectSetWithPriority(this.path_, value, priority, deferred.wrapCallback(onComplete));
     return deferred.promise;
   }
 
@@ -89,7 +89,7 @@ export class OnDisconnect {
    * @param {function(?Error)=} opt_onComplete
    * @return {!firebase.Promise}
    */
-  update(objectToMerge, opt_onComplete) {
+  update(objectToMerge, onComplete?) {
     validateArgCount('OnDisconnect.update', 1, 2, arguments.length);
     validateWritablePath('OnDisconnect.update', this.path_);
     if (Array.isArray(objectToMerge)) {
@@ -105,9 +105,9 @@ export class OnDisconnect {
     }
     validateFirebaseMergeDataArg('OnDisconnect.update', 1, objectToMerge,
       this.path_, false);
-    validateCallback('OnDisconnect.update', 2, opt_onComplete, true);
+    validateCallback('OnDisconnect.update', 2, onComplete, true);
     const deferred = new Deferred();
-    this.repo_.onDisconnectUpdate(this.path_, objectToMerge, deferred.wrapCallback(opt_onComplete));
+    this.repo_.onDisconnectUpdate(this.path_, objectToMerge, deferred.wrapCallback(onComplete));
     return deferred.promise;
   }
 }