address pr issues

Author: renkelvin

packages/auth/src/core/credentials/email.test.ts

@@ -196,7 +196,7 @@ describe('core/credentials/email', () => {
           window.grecaptcha = recaptcha;
           const stub = sinon.stub(recaptcha.enterprise, 'execute');
 
-          // First verification should fail with 'wrong-site-key'
+          // Force first verification call to fail to simulate verification error
           // Second verifcation should succeed with site key refreshed
           stub.onCall(0).rejects();
           stub.onCall(1).returns(Promise.resolve('recaptcha-response'));
@@ -210,7 +210,7 @@ describe('core/credentials/email', () => {
             recaptchaConfigResponseEnforce
           );
           await auth.initializeRecaptchaConfig();
-          auth._agentRecaptchaConfig!.siteKey = 'wrong-site-key';
+          auth._agentRecaptchaConfig!.siteKey = 'cached-site-key';
 
           const idTokenResponse = await credential._getIdTokenResponse(auth);
           expect(idTokenResponse.idToken).to.eq('id-token');

packages/auth/src/platform_browser/recaptcha/recaptcha_enterprise_verifier.test.ts

@@ -27,7 +27,10 @@ import * as mockFetch from '../../../test/helpers/mock_fetch';
 import { ServerError } from '../../api/errors';
 
 import { MockGreCAPTCHATopLevel } from './recaptcha_mock';
-import { RecaptchaEnterpriseVerifier } from './recaptcha_enterprise_verifier';
+import {
+  RecaptchaEnterpriseVerifier,
+  FAKE_TOKEN
+} from './recaptcha_enterprise_verifier';
 
 use(chaiAsPromised);
 use(sinonChai);
@@ -81,7 +84,7 @@ describe('platform_browser/recaptcha/recaptcha_enterprise_verifier', () => {
       expect(await verifier.verify()).to.eq('recaptcha-response');
     });
 
-    it('reject if error is thrown when retieve site key', async () => {
+    it('reject if error is thrown when retrieve site key', async () => {
       mockEndpointWithParams(
         Endpoint.GET_RECAPTCHA_CONFIG,
         request,
@@ -102,16 +105,16 @@ describe('platform_browser/recaptcha/recaptcha_enterprise_verifier', () => {
       );
     });
 
-    it('return fake recaptcha token if error is thrown when retieve recaptcha token', async () => {
+    it('return fake recaptcha token if error is thrown when retrieve recaptcha token', async () => {
       mockEndpointWithParams(
         Endpoint.GET_RECAPTCHA_CONFIG,
         request,
         recaptchaConfigResponseEnforce
       );
       sinon
         .stub(recaptcha.enterprise, 'execute')
-        .returns(Promise.reject(Error('retieve-recaptcha-token-error')));
-      expect(await verifier.verify()).to.eq('NO_RECAPTCHA');
+        .returns(Promise.reject(Error('retrieve-recaptcha-token-error')));
+      expect(await verifier.verify()).to.eq(FAKE_TOKEN);
     });
   });
 });