Skip to content

Commit 7cba1e6

Browse files
committed
Rename internal initializeAnalytics
1 parent 893febd commit 7cba1e6

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

packages-exp/analytics-exp/src/api.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ describe('FirebaseAnalytics API tests', () => {
3030
let app: FirebaseApp;
3131

3232
beforeEach(() => {
33-
initStub = stub(init, 'initializeAnalytics').resolves(
33+
initStub = stub(init, '_initializeAnalytics').resolves(
3434
'FAKE_MEASUREMENT_ID'
3535
);
3636
});

packages-exp/analytics-exp/src/factory.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import { getOrCreateDataLayer, wrapOrCreateGtag } from './helpers';
2121
import { AnalyticsError, ERROR_FACTORY } from './errors';
2222
import { _FirebaseInstallationsInternal } from '@firebase/installations-exp';
2323
import { areCookiesEnabled, isBrowserExtension } from '@firebase/util';
24-
import { initializeAnalytics } from './initialize-analytics';
24+
import { _initializeAnalytics } from './initialize-analytics';
2525
import { logger } from './logger';
2626
import { FirebaseApp, _FirebaseService } from '@firebase/app-exp';
2727

@@ -221,7 +221,7 @@ export function factory(
221221
}
222222
// Async but non-blocking.
223223
// This map reflects the completion state of all promises for each appId.
224-
initializationPromisesMap[appId] = initializeAnalytics(
224+
initializationPromisesMap[appId] = _initializeAnalytics(
225225
app,
226226
dynamicConfigPromisesList,
227227
measurementIdToAppId,

packages-exp/analytics-exp/src/initialize-analytics.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import { expect } from 'chai';
1919
import { SinonStub, stub } from 'sinon';
2020
import '../testing/setup';
21-
import { initializeAnalytics } from './initialize-analytics';
21+
import { _initializeAnalytics } from './initialize-analytics';
2222
import {
2323
getFakeApp,
2424
getFakeInstallations
@@ -65,7 +65,7 @@ describe('initializeAnalytics()', () => {
6565
});
6666
it('gets FID and measurement ID and calls gtag config with them', async () => {
6767
stubFetch();
68-
await initializeAnalytics(
68+
await _initializeAnalytics(
6969
app,
7070
dynamicPromisesList,
7171
measurementIdToAppId,
@@ -81,7 +81,7 @@ describe('initializeAnalytics()', () => {
8181
});
8282
it('calls gtag config with options if provided', async () => {
8383
stubFetch();
84-
await initializeAnalytics(
84+
await _initializeAnalytics(
8585
app,
8686
dynamicPromisesList,
8787
measurementIdToAppId,
@@ -99,7 +99,7 @@ describe('initializeAnalytics()', () => {
9999
});
100100
it('puts dynamic fetch promise into dynamic promises list', async () => {
101101
stubFetch();
102-
await initializeAnalytics(
102+
await _initializeAnalytics(
103103
app,
104104
dynamicPromisesList,
105105
measurementIdToAppId,
@@ -113,7 +113,7 @@ describe('initializeAnalytics()', () => {
113113
});
114114
it('puts dynamically fetched measurementId into lookup table', async () => {
115115
stubFetch();
116-
await initializeAnalytics(
116+
await _initializeAnalytics(
117117
app,
118118
dynamicPromisesList,
119119
measurementIdToAppId,
@@ -126,7 +126,7 @@ describe('initializeAnalytics()', () => {
126126
it('warns on local/fetched measurement ID mismatch', async () => {
127127
stubFetch();
128128
const consoleStub = stub(console, 'warn');
129-
await initializeAnalytics(
129+
await _initializeAnalytics(
130130
getFakeApp({ ...fakeAppParams, measurementId: 'old-measurement-id' }),
131131
dynamicPromisesList,
132132
measurementIdToAppId,

packages-exp/analytics-exp/src/initialize-analytics.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ async function validateIndexedDB(): Promise<boolean> {
6565
*
6666
* @returns Measurement ID.
6767
*/
68-
export async function initializeAnalytics(
68+
export async function _initializeAnalytics(
6969
app: FirebaseApp,
7070
dynamicConfigPromisesList: Array<
7171
Promise<DynamicConfig | MinimalDynamicConfig>

0 commit comments

Comments
 (0)