Fix how we enable fetch streams. (#7569)

wu-hui · web-flow · commit 78d2738c2465 · 2023-08-18T13:59:33.000-04:00
* Fix how we enable fetch streams.

* Create nervous-cups-relax.md
diff --git a/.changeset/nervous-cups-relax.md b/.changeset/nervous-cups-relax.md
@@ -0,0 +1,6 @@
+---
+"@firebase/firestore": patch
+"@firebase/webchannel-wrapper": patch
+---
+
+Fix how we enable fetch streams.
diff --git a/packages/firestore/src/platform/browser/webchannel_connection.ts b/packages/firestore/src/platform/browser/webchannel_connection.ts
@@ -22,7 +22,6 @@ import {
   WebChannel,
   WebChannelError,
   WebChannelOptions,
-  FetchXmlHttpFactory,
   XhrIo,
   getStatEventTarget,
   EventTarget,
@@ -209,7 +208,7 @@ export class WebChannelConnection extends RestConnection {
     }
 
     if (this.useFetchStreams) {
-      request.xmlHttpFactory = new FetchXmlHttpFactory({});
+      request.useFetchStreams = true;
     }
 
     this.modifyHeadersForRequest(
diff --git a/packages/webchannel-wrapper/src/index.d.ts b/packages/webchannel-wrapper/src/index.d.ts
@@ -108,6 +108,7 @@ export interface WebChannelOptions {
   internalChannelParams?: {
     forwardChannelRequestTimeoutMs?: number;
   };
+  useFetchStreams?: boolean;
   xmlHttpFactory?: unknown;
   requestRefreshThresholds?: { [key: string]: number };
 }

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,6 @@ import {`
`22`	`22`	`WebChannel,`
`23`	`23`	`WebChannelError,`
`24`	`24`	`WebChannelOptions,`
`25`		`- FetchXmlHttpFactory,`
`26`	`25`	`XhrIo,`
`27`	`26`	`getStatEventTarget,`
`28`	`27`	`EventTarget,`
`@@ -209,7 +208,7 @@ export class WebChannelConnection extends RestConnection {`
`209`	`208`	`}`
`210`	`209`
`211`	`210`	`if (this.useFetchStreams) {`
`212`		`- request.xmlHttpFactory = new FetchXmlHttpFactory({});`
	`211`	`+ request.useFetchStreams = true;`
`213`	`212`	`}`
`214`	`213`
`215`	`214`	`this.modifyHeadersForRequest(`
Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,7 @@ export interface WebChannelOptions {`
`108`	`108`	`internalChannelParams?: {`
`109`	`109`	`forwardChannelRequestTimeoutMs?: number;`
`110`	`110`	`};`
	`111`	`+ useFetchStreams?: boolean;`
`111`	`112`	`xmlHttpFactory?: unknown;`
`112`	`113`	`requestRefreshThresholds?: { [key: string]: number };`
`113`	`114`	`}`