make logging more palletable

Author: dconeybe

packages/firestore/scripts/run-tests.ts

@@ -82,7 +82,7 @@ function errorLog(...args: any[]): void {
   console.error(__filename, elapsedTimeStr(), ...args);
 }
 
-debugLog('command-line arguments:', process.argv);
+debugLog(`command-line arguments: ${process.argv.join(' ')}`);
 
 const argv = yargs.options({
   main: {
@@ -134,7 +134,7 @@ if (argv.persistence) {
 
 args = args.concat(argv._ as string[]);
 
-debugLog("spawning child process:", nyc, args);
+debugLog(`spawning child process: ${nyc} ${args.join(' ')}`);
 
 const childProcess = spawn(nyc, args, {
   stdio: 'inherit',

scripts/ci-test/test_changed.ts

@@ -54,7 +54,7 @@ function elapsedTimeStr(): string {
 let elapsedMillisecondsStartTime: number | null = null;
 
 /**
- * Returns the number of nanoseconds that have elapsed since this function's
+ * Returns the number of milliseconds that have elapsed since this function's
  * first invocation. Returns 0 on its first invocation.
  */
 function getElapsedMilliseconds(): number {
@@ -84,7 +84,7 @@ function errorLog(...args: any[]): void {
   console.error(__filename, elapsedTimeStr(), ...args);
 }
 
-debugLog('command-line arguments:', process.argv);
+debugLog(`command-line arguments: ${process.argv.join(' ')}`);
 
 const argv = yargs.parseSync();
 const inputTestConfigName = argv._[0].toString();
@@ -139,9 +139,9 @@ async function runTests(config: TestConfig) {
     }
 
     lernaCmd.push(testCommand);
-    debugLog('spawning process: npx', lernaCmd);
+    debugLog(`spawning process: npx ${lernaCmd.join(' ')}`);
     await spawn('npx', lernaCmd, { stdio: 'inherit', cwd: root });
-    debugLog('process completed successfully: npx', lernaCmd);
+    debugLog(`process completed successfully: npx ${lernaCmd.join(' ')}`);
     process.exit(0);
   } catch (e) {
     errorLog('process failed');

scripts/run_tests_in_ci.js

@@ -81,7 +81,7 @@ function errorLog(...args) {
   console.error(__filename, elapsedTimeStr(), ...args);
 }
 
-debugLog('command-line arguments:', process.argv);
+debugLog(`command-line arguments: ${process.argv.join(' ')}`);
 
 const LOGDIR = process.env.CI ? process.env.HOME : '/tmp';
 // Maps the packages where we should not run `test:all` and instead isolate the cross-browser tests.
@@ -134,7 +134,7 @@ const argv = yargs.options({
     }
 
     const yarnArgs = ['--cwd', dir, scriptName];
-    debugLog(`spawning '${name}' process:`, 'yarn', yarnArgs);
+    debugLog(`spawning '${name}' process: yarn ${yarnArgs.join(' ')}`);
     const testProcess = spawn('yarn', yarnArgs);
 
     testProcess.childProcess.stdout.on('data', data => {
@@ -145,18 +145,20 @@ const argv = yargs.options({
     });
 
     await testProcess;
-    debugLog(`${name} process completed successfully:`, 'yarn', yarnArgs);
+    debugLog(
+      `'${name}' process completed successfully: yarn ${yarnArgs.join(' ')}`
+    );
     writeLogs('Success', name, stdout + '\n' + stderr);
   } catch (e) {
     errorLog(`${name} process FAILED`);
-    debugLog(`${name} process ==== STDOUT BEGIN ====`);
+    errorLog(`${name} process ==== STDOUT BEGIN ====`);
     console.log(stdout);
-    debugLog(`${name} process ==== STDOUT END ====`);
-    debugLog(`${name} process ==== STDERR BEGIN ====`);
+    errorLog(`${name} process ==== STDOUT END ====`);
+    errorLog(`${name} process ==== STDERR BEGIN ====`);
     console.error(stderr);
-    debugLog(`${name} process ==== STDERR END ====`);
+    errorLog(`${name} process ==== STDERR END ====`);
     writeLogs('Failure', name, stdout + '\n' + stderr);
-    debugLog('Completing with failure exit code 76');
+    errorLog('Completing with failure exit code 76');
     process.exit(76);
   }
 })();