Feedback

Author: wu-hui

packages/firestore/test/unit/local/counting_query_engine.ts

@@ -48,8 +48,8 @@ export class CountingQueryEngine extends QueryEngine {
   overlayTypes: { [k: string]: MutationType } = {};
 
   /**
-   * The number of documents returned by the RemoteDocumentCache's //
-   * `getAll()` API (since the last call to `resetCounts()`) //
+   * The number of documents returned by the RemoteDocumentCache's
+   * `getAll()` API (since the last call to `resetCounts()`).
    */
   documentsReadByCollection = 0;
 
@@ -185,9 +185,9 @@ export class CountingQueryEngine extends QueryEngine {
       },
 
       getOverlaysForCollectionGroup: (
-        transaction,
-        collectionGroup,
-        sinceBatchId,
+        transaction: PersistenceTransaction,
+        collectionGroup: string,
+        sinceBatchId: number,
         count: number
       ) => {
         return subject

packages/firestore/test/unit/local/local_store.test.ts

@@ -2005,7 +2005,7 @@ function genericLocalStoreTests(
       .finish();
   });
 
-  it('can handle multiple field patches on local docs', () => {
+  it('update on remote doc leads to update overlay', () => {
     expect(new Map([['a', 1]])).to.deep.equal(new Map([['a', 0]]));
     return expectLocalStore()
       .afterAllocatingQuery(query('foo'))