Implement Index Scanning

Author: schmidt-sebastian

packages/firestore/src/core/target.ts

@@ -333,9 +333,10 @@ export function targetGetLowerBound(
           filterValue = MIN_VALUE;
           break;
         case Operator.NOT_IN:
-          const length = (fieldFilter.value.arrayValue!.values || []).length;
+          // Porting Note: The Web SDK implements NotIn queries different from
+          // Android and only uses a single element array as a NotIn bound.
           filterValue = {
-            arrayValue: { values: new Array(length).fill(MIN_VALUE) }
+            arrayValue: { values: [MIN_VALUE] }
           };
           break;
         default:
@@ -418,9 +419,10 @@ export function targetGetUpperBound(
           filterValue = MAX_VALUE;
           break;
         case Operator.NOT_IN:
-          const length = (fieldFilter.value.arrayValue!.values || []).length;
+          // Porting Note: The Web SDK implements NotIn queries different from
+          // Android and only uses a single element array as a NotIn bound.
           filterValue = {
-            arrayValue: { values: new Array(length).fill(MIN_VALUE) }
+            arrayValue: { values: [MAX_VALUE] }
           };
           break;
         default:

packages/firestore/src/index/index_entry.ts

@@ -49,7 +49,7 @@ export function indexEntryComparator(
   return compareByteArrays(left.directionalValue, right.directionalValue);
 }
 
-function compareByteArrays(left: Uint8Array, right: Uint8Array): number {
+export function compareByteArrays(left: Uint8Array, right: Uint8Array): number {
   for (let i = 0; i < left.length && i < right.length; ++i) {
     const compare = left[i] - right[i];
     if (compare !== 0) {

packages/firestore/src/local/index_manager.ts

@@ -103,13 +103,12 @@ export interface IndexManager {
 
   /**
    * Returns the documents that match the given target based on the provided
-   * index.
+   * index. Returns `null` if the target does not have a matching index.
    */
   getDocumentsMatchingTarget(
     transaction: PersistenceTransaction,
-    fieldIndex: FieldIndex,
     target: Target
-  ): PersistencePromise<DocumentKeySet>;
+  ): PersistencePromise<DocumentKeySet | null>;
 
   /**
    * Returns the next collection group to update. Returns `null` if no group