Merge 30e6996 into d638a42

Author: samtstern

.changeset/dirty-hotels-cheat.md

@@ -0,0 +1,5 @@
+---
+'@firebase/database': patch
+---
+
+Fix issue with multiple database instances when using Realtime Database emulator (#3681)

packages/database/src/core/RepoInfo.ts

@@ -128,6 +128,10 @@ export class RepoInfo {
 
   /** @return {string} */
   toURLString(): string {
-    return (this.secure ? 'https://' : 'http://') + this.host;
+    const protocol = this.secure ? 'https://' : 'http://';
+    const query = this.includeNamespaceInQueryParams
+      ? `?ns=${this.namespace}`
+      : '';
+    return `${protocol}${this.host}/${query}`;
   }
 }

packages/database/test/database.test.ts

@@ -149,13 +149,35 @@ describe('Database Tests', () => {
     expect(db2.ref().toString()).to.equal('https://foo2.bar.com/');
   });
 
+  it('Different instances for different URLs (with FIREBASE_DATABASE_EMULATOR_HOST)', () => {
+    process.env['FIREBASE_DATABASE_EMULATOR_HOST'] = 'localhost:9000';
+    const db1 = defaultApp.database('http://foo1.bar.com');
+    const db2 = defaultApp.database('http://foo2.bar.com');
+    expect(db1.repo_.repoInfo_.toURLString()).to.equal(
+      'http://localhost:9000/?ns=foo1'
+    );
+    expect(db2.repo_.repoInfo_.toURLString()).to.equal(
+      'http://localhost:9000/?ns=foo2'
+    );
+    delete process.env['FIREBASE_DATABASE_EMULATOR_HOST'];
+  });
+
   it('Cannot use same URL twice', () => {
     defaultApp.database('http://foo.bar.com');
     expect(() => {
       defaultApp.database('http://foo.bar.com/');
     }).to.throw(/Database initialized multiple times/i);
   });
 
+  it('Cannot use same URL twice (with FIREBASE_DATABASE_EMULATOR_HOST)', () => {
+    process.env['FIREBASE_DATABASE_EMULATOR_HOST'] = 'localhost:9000';
+    defaultApp.database('http://foo.bar.com');
+    expect(() => {
+      defaultApp.database('http://foo.bar.com/');
+    }).to.throw(/Database initialized multiple times/i);
+    delete process.env['FIREBASE_DATABASE_EMULATOR_HOST'];
+  });
+
   it('Databases with legacy domain', () => {
     expect(() => {
       defaultApp.database('http://foo.firebase.com/');