Test cleanup: Create indexeddbshim SQLite files in a temporary directory now that indexeddbshim/IndexedDBShim#319 is fixed. (#781)

Author: mikelehen

packages/firestore/.gitignore

@@ -40,7 +40,7 @@
     "@types/mocha": "5.0.0",
     "@types/sinon": "4.3.1",
     "chai": "4.1.2",
-    "indexeddbshim":"3.6.1",
+    "indexeddbshim":"3.6.2",
     "karma": "2.0.0",
     "karma-chrome-launcher": "2.2.0",
     "karma-cli": "1.0.1",
@@ -53,7 +53,6 @@
     "long": "3.2.0",
     "mkdirp": "0.5.1",
     "mocha": "5.0.5",
-    "node-cleanup": "2.1.2",
     "npm-run-all": "4.1.2",
     "nyc": "11.6.0",
     "rollup": "0.57.1",

packages/firestore/package.json

@@ -16,7 +16,7 @@
 
 import * as registerIndexedDBShim from 'indexeddbshim';
 import * as fs from 'fs';
-import * as nodeCleanup from 'node-cleanup';
+import * as os from 'os';
 
 // WARNING: The `indexeddbshim` installed via this module should only ever be
 // used during initial development. Always validate your changes via
@@ -28,29 +28,15 @@ import * as nodeCleanup from 'node-cleanup';
 
 const globalAny = global as any; // tslint:disable-line:no-any
 
+const dbDir = fs.mkdtempSync(os.tmpdir() + '/firestore_tests');
+
 if (process.env.USE_MOCK_PERSISTENCE === 'YES') {
   registerIndexedDBShim(null, {
     checkOrigin: false,
+    databaseBasePath: dbDir,
     deleteDatabaseFiles: true
   });
   globalAny.window = Object.assign(globalAny.window || {}, {
     indexedDB: globalAny.indexedDB
   });
-}
-
-// `deleteDatabaseFiles` does not reliable delete all SQLite files. Before
-// we exit the Node process, we attempt to delete all lingering "*.sqllite"
-// files.
-const existingFiles = new Set<string>();
-
-fs.readdirSync('.').forEach(file => {
-  existingFiles.add(file);
-});
-
-nodeCleanup(() => {
-  fs.readdirSync('.').forEach(file => {
-    if (file.endsWith('.sqlite') && !existingFiles.has(file)) {
-      fs.unlinkSync(file);
-    }
-  });
-});
+}

packages/firestore/test/util/node_persistence.ts

@@ -4991,9 +4991,9 @@ indent-string@^3.0.0:
   version "3.2.0"
   resolved "https://registry.npmjs.org/indent-string/-/indent-string-3.2.0.tgz#4a5fd6d27cc332f37e5419a504dbb837105c9289"
 
-[email protected].1:
-  version "3.6.1"
-  resolved "https://registry.npmjs.org/indexeddbshim/-/indexeddbshim-3.6.1.tgz#a0eff29ebfd4b46b5c914dd32e2306d8bc7dd8fe"
+[email protected].2:
+  version "3.6.2"
+  resolved "https://registry.npmjs.org/indexeddbshim/-/indexeddbshim-3.6.2.tgz#281fe257595e96fec242f00639f4ce66855cda32"
   dependencies:
     babel-polyfill "6.26.0"
     eventtargeter "0.4.0"
@@ -7160,10 +7160,6 @@ nise@^1.2.0:
     path-to-regexp "^1.7.0"
     text-encoding "^0.6.4"
 
-[email protected]:
-  version "2.1.2"
-  resolved "https://registry.npmjs.org/node-cleanup/-/node-cleanup-2.1.2.tgz#7ac19abd297e09a7f72a71545d951b517e4dde2c"
-
 [email protected]:
   version "2.1.2"
   resolved "https://registry.npmjs.org/node-fetch/-/node-fetch-2.1.2.tgz#ab884e8e7e57e38a944753cec706f788d1768bb5"