Skip to content

Commit 0267c69

Browse files
committed
resolve comments
1 parent 3a6cc27 commit 0267c69

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.changeset/hot-insects-wink.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
'@firebase/firestore': minor
33
---
44

5-
Release count query for internal use.
5+
Implement count query for internal use.

packages/firestore/src/core/firestore_client.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -525,9 +525,10 @@ export function firestoreClientRunCountQuery(
525525
'Failed to get count result because the client is offline.'
526526
)
527527
);
528+
} else {
529+
const result = await getCount(query);
530+
deferred.resolve(result);
528531
}
529-
const result = await getCount(query);
530-
deferred.resolve(result);
531532
} catch (e) {
532533
deferred.reject(e as Error);
533534
}

0 commit comments

Comments
 (0)