Skip to content

Standardize transaction retries to attempts #8314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2021
Merged

Standardize transaction retries to attempts #8314

merged 2 commits into from
Jun 30, 2021

Conversation

@thebrianchen
Copy link

@thebrianchen thebrianchen commented Jun 28, 2021

Porting from android.

@thebrianchen thebrianchen self-assigned this Jun 28, 2021
@google-cla google-cla bot added the cla: yes label Jun 28, 2021
@google-oss-bot
Copy link

google-oss-bot commented Jun 28, 2021

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

google-oss-bot commented Jun 28, 2021

Coverage Report

Affected SDKs

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    SDK overall coverage changed from 88.51% (89f237a) to 88.50% (066c33c) by -0.01%.

    Filename Base (89f237a) Head (066c33c) Diff
    leveldb_key.cc 97.52% 96.79% -0.73%
    ordered_code.cc 92.68% 93.24% +0.56%

Test Logs

@thebrianchen thebrianchen merged commit 38a7b1f into master Jun 30, 2021
@thebrianchen thebrianchen deleted the bc/tx-attempts branch June 30, 2021 15:48
@firebase firebase locked and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@schmidt-sebastian schmidt-sebastian

Labels

api: firestore cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thebrianchen @google-oss-bot @schmidt-sebastian