Skip to content

Update firestore emulator version in tests #6420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2020
Merged

Update firestore emulator version in tests #6420

merged 1 commit into from
Sep 9, 2020

Conversation

thebrianchen
Copy link

Updating emulator version to v1.11.7 to include support for != queries.

@thebrianchen thebrianchen self-assigned this Sep 8, 2020
@thebrianchen thebrianchen requested a review from wilhuff September 9, 2020 15:03
wilhuff
wilhuff approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned thebrianchen and unassigned wilhuff Sep 9, 2020
@thebrianchen thebrianchen merged commit fa04212 into master Sep 9, 2020
@thebrianchen thebrianchen deleted the bc/update-emu branch September 9, 2020 19:08
@firebase firebase locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@wilhuff wilhuff wilhuff approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@thebrianchen thebrianchen

Labels
api: firestore cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thebrianchen @wilhuff @googlebot