Skip to content

Apply bloom filter on existence filter mismatch #10953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Mar 23, 2023
Merged

Apply bloom filter on existence filter mismatch #10953

merged 41 commits into from
Mar 23, 2023

Conversation

@milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Mar 14, 2023 •
edited
Loading

#no-changelog

milaGGL added 14 commits February 23, 2023 17:33
@milaGGL
add unchanged names to existence filter and modify spec test runner
969f2ed
@milaGGL
Merge branch 'mila/BloomFilter' into mila/BloomFilter-add--existence-…
b66b02b 
…filter-class
@milaGGL
use BloomFilter instead of proto
1df9410
@milaGGL
update serializer
1e67033
@milaGGL
add bloomfilter equality test
899e3cc
@milaGGL
Merge branch 'mila/BloomFilter' into mila/BloomFilter-add--existence-…
3faa3e8 
…filter-class
@milaGGL
make unchanged_names optional in proto
468f967
@milaGGL
handle invalid unchanged-names input with BloomFilter::Create
23f0fb1
@milaGGL
format the comments
475fffb
@milaGGL
Merge branch 'mila/BloomFilter' into mila/BloomFilter-add--existence-…
5bda231 
…filter-class
@milaGGL
port spec tests
11158e5
@milaGGL
change unchanged_names to Bloom_filter
05caaeb
@milaGGL
add GetDatabaseId to the targetMetadataProvider
b0bb8bf
@milaGGL
remove the parsing unchanged_names to BloomFilter logic
d56f4df
@milaGGL milaGGL self-assigned this Mar 14, 2023
milaGGL added 10 commits March 14, 2023 12:21
@milaGGL
sort the actual and expected events in spec test before comparing them
4158352
@milaGGL
Merge branch 'mila/BloomFilter-add--existence-filter-class' into mila…
2b8533c 
…/BloomFilter-apply-bloom-filter-on-existence-filter-mismatch
@milaGGL
Revert "Merge branch 'mila/BloomFilter-add--existence-filter-class' i…
ae930ef 
…nto mila/BloomFilter-apply-bloom-filter-on-existence-filter-mismatch"

This reverts commit 2b8533c, reversing
changes made to 4158352.
@milaGGL
resolve comments
91a42e6
@milaGGL
Merge branch 'mila/BloomFilter' into mila/BloomFilter-add--existence-…
e694551 
…filter-class
@milaGGL
Merge branch 'mila/BloomFilter-add--existence-filter-class' into mila…
db883fb 
…/BloomFilter-apply-bloom-filter-on-existence-filter-mismatch
@milaGGL
format
a2b7408
@milaGGL
log error message
f6b062f
@milaGGL
Merge branch 'mila/BloomFilter' into mila/BloomFilter-apply-bloom-fil…
0de7946 
…ter-on-existence-filter-mismatch
@milaGGL
merge queryPurpose spec test check
01c332b
@milaGGL milaGGL changed the base branch from mila/BloomFilter-add--existence-filter-class to mila/BloomFilter March 17, 2023 03:37
milaGGL
milaGGL commented Mar 20, 2023
View reviewed changes
@milaGGL milaGGL marked this pull request as ready for review March 20, 2023 19:25
milaGGL
milaGGL commented Mar 20, 2023
View reviewed changes
milaGGL
milaGGL commented Mar 20, 2023
View reviewed changes
@milaGGL milaGGL requested a review from dconeybe March 20, 2023 21:23
@milaGGL milaGGL mentioned this pull request Mar 21, 2023
Merged
dconeybe
dconeybe requested changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! Mostly minor comments.

@dconeybe dconeybe mentioned this pull request Mar 21, 2023
Closed
@milaGGL milaGGL requested a review from dconeybe March 22, 2023 01:00
dconeybe
dconeybe requested changes Mar 22, 2023
View reviewed changes
@milaGGL milaGGL requested a review from dconeybe March 22, 2023 22:50
dconeybe
dconeybe requested changes Mar 23, 2023
View reviewed changes
@milaGGL milaGGL requested a review from dconeybe March 23, 2023 17:44
@milaGGL milaGGL merged commit b761c5f into mila/BloomFilter Mar 23, 2023
@milaGGL milaGGL deleted the mila/BloomFilter-apply-bloom-filter-on-existence-filter-mismatch branch March 23, 2023 20:38
@firebase firebase locked and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@milaGGL milaGGL

Labels

api: firestore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@milaGGL @dconeybe @google-oss-bot