Skip to content

Avoid deeply nested timestamps that can cause stack overflow. #10916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2023
Merged

Avoid deeply nested timestamps that can cause stack overflow. #10916

merged 1 commit into from
Mar 20, 2023

Conversation

@ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Mar 9, 2023

This is porting the fix from firebase/firebase-android-sdk#4715 which prevents deeply nested timestamps and fixes a potential stack overflow error.

This may also be the root cause of #10469.

@ehsannas ehsannas self-assigned this Mar 9, 2023
@ehsannas ehsannas marked this pull request as draft March 9, 2023 00:38
@ehsannas ehsannas force-pushed the ehsann/fix-deeply-nested-timestamps branch from 64d10d1 to be3e0bf Compare March 13, 2023 18:49
@ehsannas ehsannas force-pushed the ehsann/fix-deeply-nested-timestamps branch from be3e0bf to 0bc9d0b Compare March 13, 2023 19:00
@google-oss-bot
Copy link

google-oss-bot commented Mar 13, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.27% (4b29816) to 88.26% (45a3608) by -0.01%.

    FilenameBase (4b29816)Merge (45a3608)Diff
    ordered_code.cc94.39%93.90%-0.49%
    server_timestamp_util.cc97.06%95.77%-1.28%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1335Mgcl7c.html

@ehsannas ehsannas marked this pull request as ready for review March 13, 2023 20:25
@ehsannas ehsannas requested a review from wu-hui March 17, 2023 22:31
@ehsannas ehsannas assigned wu-hui and unassigned ehsannas Mar 17, 2023
@wu-hui wu-hui assigned ehsannas and unassigned wu-hui Mar 20, 2023
@ehsannas ehsannas merged commit 9aaa3d2 into master Mar 20, 2023
@ehsannas ehsannas deleted the ehsann/fix-deeply-nested-timestamps branch March 20, 2023 18:09
@firebase firebase locked and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@ehsannas ehsannas

Labels

api: firestore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ehsannas @google-oss-bot @wu-hui