Skip to content

Commit f4e74ba

Browse files
author
Brian Chen
committed
small fixes
1 parent 38836df commit f4e74ba

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

Firestore/Swift/Tests/API/BasicCompileTests.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ func makeQuery(collection collectionRef: CollectionReference) -> Query {
111111
.whereField(FieldPath(["tags"]), notIn: ["active", "squat"])
112112
.whereField(FieldPath.documentID(), isEqualTo: "fred")
113113
.whereField(FieldPath.documentID(), isNotEqualTo: "fred")
114+
.whereField(FieldPath(["name"]), isEqualTo: "fred")
114115
.order(by: FieldPath(["age"]))
115116
.order(by: "name", descending: true)
116117
.limit(to: 10)

Firestore/core/src/core/key_field_not_in_filter.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ namespace firestore {
2626
namespace core {
2727

2828
/**
29-
* A Filter that matches on key fields not present within an array..
29+
* A Filter that matches on key fields not present within an array.
3030
*/
3131
class KeyFieldNotInFilter : public FieldFilter {
3232
public:

Firestore/core/src/remote/serializer.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1114,15 +1114,15 @@ google_firestore_v1_StructuredQuery_Filter Serializer::EncodeSingularFilter(
11141114
auto op =
11151115
filter.op() == Filter::Operator::Equal
11161116
? google_firestore_v1_StructuredQuery_UnaryFilter_Operator_IS_NAN
1117-
: google_firestore_v1_StructuredQuery_UnaryFilter_Operator_IS_NOT_NAN;
1117+
: google_firestore_v1_StructuredQuery_UnaryFilter_Operator_IS_NOT_NAN; // NOLINT
11181118
result.unary_filter.op = op;
11191119
return result;
11201120

11211121
} else if (filter.value().is_null()) {
11221122
auto op =
11231123
filter.op() == Filter::Operator::Equal
11241124
? google_firestore_v1_StructuredQuery_UnaryFilter_Operator_IS_NULL
1125-
: google_firestore_v1_StructuredQuery_UnaryFilter_Operator_IS_NOT_NULL;
1125+
: google_firestore_v1_StructuredQuery_UnaryFilter_Operator_IS_NOT_NULL; // NOLINT
11261126
result.unary_filter.op = op;
11271127
return result;
11281128
}

0 commit comments

Comments
 (0)