Remove logging count for this release. (#1201)

Author: ryanwilson

Example/Core/Tests/FIRLoggerTest.m

@@ -239,33 +239,6 @@ - (void)testFIRLoggerLevelValues {
   XCTAssertEqual(FIRLoggerLevelDebug, ASL_LEVEL_DEBUG);
 }
 
-- (void)testErrorNumberIncrement {
-  OCMStub([self.userDefaultsMock integerForKey:kFIRLoggerErrorCountKey]).andReturn(10);
-  OCMExpect([self.userDefaultsMock setInteger:11 forKey:kFIRLoggerErrorCountKey]);
-  FIRLogError(kFIRLoggerCore, kMessageCode, @"Error.");
-
-  // Use a delay since the logging is async.
-  OCMVerifyAllWithDelay(self.userDefaultsMock, 1);
-}
-
-- (void)testWarningNumberIncrement {
-  OCMStub([self.userDefaultsMock integerForKey:kFIRLoggerWarningCountKey]).andReturn(1);
-  OCMExpect([self.userDefaultsMock setInteger:2 forKey:kFIRLoggerWarningCountKey]);
-  FIRLogWarning(kFIRLoggerCore, kMessageCode, @"Warning.");
-
-  // Use a delay since the logging is async.
-  OCMVerifyAllWithDelay(self.userDefaultsMock, 1);
-}
-
-- (void)testResetIssuesCount {
-  OCMExpect([self.userDefaultsMock setInteger:0 forKey:kFIRLoggerErrorCountKey]);
-  OCMExpect([self.userDefaultsMock setInteger:0 forKey:kFIRLoggerWarningCountKey]);
-  FIRResetNumberOfIssuesLogged();
-
-  // Use a delay since the logging is async.
-  OCMVerifyAllWithDelay(self.userDefaultsMock, 1);
-}
-
 // Helper functions.
 - (BOOL)logExists {
   [self drainFIRClientQueue];

Firebase/Core/FIRLogger.m

@@ -186,7 +186,6 @@ BOOL FIRIsLoggableLevel(FIRLoggerLevel loggerLevel, BOOL analyticsComponent) {
 #ifdef DEBUG
 void FIRResetLogger() {
   sFIRLoggerOnceToken = 0;
-  FIRResetNumberOfIssuesLogged();
   [[NSUserDefaults standardUserDefaults] removeObjectForKey:kFIRPersistedDebugModeKey];
 }
 
@@ -233,17 +232,6 @@ void FIRLogBasic(FIRLoggerLevel level,
   dispatch_async(sFIRClientQueue, ^{
     asl_log(sFIRLoggerClient, NULL, level, "%s", logMsg.UTF8String);
   });
-
-  // Keep count of how many errors and warnings are triggered.
-  if (level == FIRLoggerLevelError) {
-    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
-    NSInteger errorCount = [defaults integerForKey:kFIRLoggerErrorCountKey];
-    [defaults setInteger:errorCount + 1 forKey:kFIRLoggerErrorCountKey];
-  } else if (level == FIRLoggerLevelWarning) {
-    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
-    NSInteger warningCount = [defaults integerForKey:kFIRLoggerWarningCountKey];
-    [defaults setInteger:warningCount + 1 forKey:kFIRLoggerWarningCountKey];
-  }
 }
 #pragma clang diagnostic pop
 
@@ -271,21 +259,6 @@ void FIRLogBasic(FIRLoggerLevel level,
 
 #undef FIR_MAKE_LOGGER
 
-#pragma mark - Number of errors and warnings
-
-NSInteger FIRNumberOfErrorsLogged(void) {
-  return [[NSUserDefaults standardUserDefaults] integerForKey:kFIRLoggerErrorCountKey];
-}
-
-NSInteger FIRNumberOfWarningsLogged(void) {
-  return [[NSUserDefaults standardUserDefaults] integerForKey:kFIRLoggerWarningCountKey];
-}
-
-void FIRResetNumberOfIssuesLogged(void) {
-  [[NSUserDefaults standardUserDefaults] setInteger:0 forKey:kFIRLoggerErrorCountKey];
-  [[NSUserDefaults standardUserDefaults] setInteger:0 forKey:kFIRLoggerWarningCountKey];
-}
-
 #pragma mark - FIRLoggerWrapper
 
 @implementation FIRLoggerWrapper

Firebase/Core/Private/FIRLogger.h

@@ -71,21 +71,6 @@ void FIRSetAnalyticsDebugMode(BOOL analyticsDebugMode);
  */
 void FIRSetLoggerLevel(FIRLoggerLevel loggerLevel);
 
-/**
- * Retrieve the number of errors that have been logged since the stat was last reset.
- */
-NSInteger FIRNumberOfErrorsLogged(void);
-
-/**
- * Retrieve the number of warnings that have been logged since the stat was last reset.
- */
-NSInteger FIRNumberOfWarningsLogged(void);
-
-/**
- * Reset number of errors and warnings that have been logged to 0.
- */
-void FIRResetNumberOfIssuesLogged(void);
-
 /**
  * Checks if the specified logger level is loggable given the current settings.
  * (required) log level (one of the FIRLoggerLevel enum values).